Use the path parameter of encode/decode again to be future-proof#223
Closed
syssi wants to merge 1 commit intorytilahti:masterfrom
Closed
Use the path parameter of encode/decode again to be future-proof#223syssi wants to merge 1 commit intorytilahti:masterfrom
syssi wants to merge 1 commit intorytilahti:masterfrom
Conversation
2 similar comments
Owner
|
I suppose the question to ask here is whether we are more afraid of potential silent errors (which we can handle by checking against incoming kwargs) or changes in the interface used by construct. Maybe keeping the path as it is, and adding |
Contributor
|
There's still an open issue #224 when using Construct > 2.9.28. |
Contributor
|
Instead of crashing "immediately" due to error explictly related to Adapter code, it will fail "later" due to unknown reasons that dont flag construct lines of code in any way. You might as well wrap you entire code in try/catch and ship it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cp. #220 (comment)