Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: types improvements #226

Merged
merged 1 commit into from
Sep 30, 2023
Merged

chore: types improvements #226

merged 1 commit into from
Sep 30, 2023

Conversation

alexcastrodev
Copy link
Collaborator

What's new ?

  • It helps to uniform the errors from API Services
  • It check format and linting from all PR
  • It stardandize the logger function
  • It add Rate limit error
  • it will not save render of rate limited calls
  • It only cache success request

@vercel
Copy link

vercel bot commented Sep 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
github-profile-trophy ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2023 0:34am

@alexcastrodev
chore: types improvements
c94f268 
chore: types improvements

chore: types improvements
@alexcastrodev alexcastrodev force-pushed the chore/types-improvements branch from 3213b6f to c94f268 Compare September 30, 2023 00:34
@alexcastrodev alexcastrodev mentioned this pull request Sep 30, 2023
Closed
@alexcastrodev
Copy link
Collaborator Author

@ryo-ma Sorry for closing the previous, i deleted my fork, and it closes the 2 PR i have made.

@ryo-ma ryo-ma merged commit 495eba6 into master Sep 30, 2023
2 checks passed
@commit-lint commit-lint bot mentioned this pull request Sep 30, 2023
Open
@ryo-ma
Copy link
Owner

ryo-ma commented Sep 30, 2023

@alexcastrodev
I noticed after merging that the "not found" error log always appears when the rate limit is exceeded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryo-ma ryo-ma Awaiting requested review from ryo-ma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexcastrodev @ryo-ma