Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Account Duration/Experience Trophy #203

Merged
merged 5 commits into from
Oct 3, 2023
Merged

Added Account Duration/Experience Trophy #203

merged 5 commits into from
Oct 3, 2023

Conversation

bhavberi
Copy link
Contributor

Addition: Trophy named Experience
Conditioning: Based on the Number of Days since account creation
Points Calculation: Number of Days/100 & rounded down
Rank Updates: Kind of Linear exponential

The output of deno lint --unstable:
Screenshot from 2023-05-16 13-11-11

For username=ryo-ma
image

FYI: Based on a comment too - #174 (review)

Hope I can get this PR merged. (Please let me know if you want any changes in the rank titles or conditionals for the ranks)
~ @bhavberi

@vercel
Copy link

vercel bot commented May 21, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @ryo-ma on Vercel.

@ryo-ma first needs to authorize it.

@bhavberi bhavberi mentioned this pull request May 21, 2023
Closed
MitkoVtori
MitkoVtori approved these changes Jun 30, 2023
View reviewed changes
Copy link

@MitkoVtori MitkoVtori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like that trophy!

@CSFelix
Copy link

CSFelix commented Sep 21, 2023

Great idea!!

@AlexcastroDev
Copy link
Collaborator

Addition: Trophy named Experience Conditioning: Based on the Number of Days since account creation Points Calculation: Number of Days/100 & rounded down Rank Updates: Kind of Linear exponential

The output of deno lint --unstable: Screenshot from 2023-05-16 13-11-11

For username=ryo-ma image

FYI: Based on a comment too - #174 (review)

Hope I can get this PR merged. (Please let me know if you want any changes in the rank titles or conditionals for the ranks) ~ @bhavberi

Congrats !!

Sorry for wait long time for review. I will try help @ryo-ma.

Ryota, can you review this ?

@ryo-ma
Copy link
Owner

ryo-ma commented Oct 1, 2023

@bhavberi can you rebase?

@bhavberi
Copy link
Contributor Author

bhavberi commented Oct 1, 2023

@ryo-ma Can you please check it once?

@bhavberi bhavberi mentioned this pull request Oct 1, 2023
Closed
@ryo-ma
Copy link
Owner

ryo-ma commented Oct 1, 2023

@bhavberi I'll review it after work today.

@vercel
Copy link

vercel bot commented Oct 1, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
github-profile-trophy ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 2:54pm

@AlexcastroDev
Copy link
Collaborator

@bhavberi I am sorry, this format was my fault, can you rebase with master ?
I updated the master code with formated fixed.

I am sorry again.

@bhavberi
Copy link
Contributor Author

bhavberi commented Oct 3, 2023

Done 👍

@ryo-ma
Copy link
Owner

ryo-ma commented Oct 3, 2023

Sorry, please one more rebase. I will merge this PR next.

@AlexcastroDev
Copy link
Collaborator

Sorry, please one more rebase. I will merge this PR next.

I helped in this one, he is waiting since may :(

@ryo-ma ryo-ma merged commit 0cc5b5c into ryo-ma:master Oct 3, 2023
3 checks passed
@ryo-ma
Copy link
Owner

ryo-ma commented Oct 3, 2023

Thank you for your PR. I have merged.

@ivan-developer-01
Copy link

Yay!

@bhavberi bhavberi deleted the experience_trophy branch October 3, 2023 15:57
SmashedFrenzy16
SmashedFrenzy16 reviewed Oct 4, 2023
View reviewed changes
Copy link
Contributor

@SmashedFrenzy16 SmashedFrenzy16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea for a trophy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryo-ma ryo-ma ryo-ma left review comments

@AlexcastroDev AlexcastroDev AlexcastroDev left review comments

@SmashedFrenzy16 SmashedFrenzy16 SmashedFrenzy16 left review comments

@MitkoVtori MitkoVtori MitkoVtori approved these changes

@ivan-developer-01 ivan-developer-01 ivan-developer-01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@bhavberi @CSFelix @AlexcastroDev @ryo-ma @ivan-developer-01 @SmashedFrenzy16 @MitkoVtori