Skip to content

Conversation

@rydmike
Copy link
Owner

@rydmike rydmike commented Oct 8, 2024

The following four links to reference pages on the Flutter web site page https://docs.flutter.dev/release/breaking-changes/new-color-scheme-roles are broken:

They are broken due to wrong syntax in the markdown file, used URLs are otherwise correct, but the used extended markdown link syntax is not, causing the links to be broken.

This PR fixes the error so the links work.

Description of what this PR is changing or adding, and why:

Issues fixed by this PR (if any):

PRs or commits this PR depends on (if any):

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

The following four links to reference pages on the Flutter web site page https://docs.flutter.dev/release/breaking-changes/new-color-scheme-roles are broken:

- [Support fidelity variant for ColorScheme.fromSeed](flutter/flutter#144649)
- [Introduce tone-based surfaces and accent color add-ons - Part 1](flutter/flutter#142654)
- [Introduce tone-based surfaces and accent color add-ons - Part 2](flutter/flutter#138521)
- [Enhance ColorScheme.fromSeed with a new variant parameter](flutter/flutter#144805)

They are broken due to wrong syntax in the markdown file, used URLs are otherwise correct, but the used extended markdown link syntax is not, causing the links to be broken.

This PR fixes the error so the links work.
@rydmike rydmike merged commit 473978c into main Oct 8, 2024
@rydmike rydmike deleted the rydmike-fix-links-on-new-color-scheme-roles branch October 8, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants