Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified to support multiple project keys #77

Merged
merged 2 commits into from
Mar 10, 2024
Merged

Conversation

kamesh-09
Copy link
Contributor

@kamesh-09 kamesh-09 commented Feb 27, 2024

Currently the action supports only one project key.
Added support so multiple keys can be configured for PR title.
All keys can be defined on new lines, for eg:

 name: Enforce Jira Issue Key in Pull Request Title
  uses: ryanvade/enforce-pr-title-style-action@v2
  with:
    projectKeys: | 
      'AB'
      'CD'
      'EF'
    separator: ':'

Added new test cases and modified existing one.
This is a Breaking Change since projectKey is now renamed as projectKeys

@ryanvade
Copy link
Owner

ryanvade commented Mar 3, 2024

Hey @kamesh-09 thank you for your PR. Before merging the changes in I would like to see a few changes made. First, I think the overall goal of this PR can be achieved without adding a breaking change.

Lets keep the use of projectKey while also adding the new projectKeys option that way existing users of this action can upgrade without issue.

Second, since this PR adds a new configuration option please make sure to update the README with documentation on how the new feature works.

Let me know if you want me to add these changes.

@kamesh-09
Copy link
Contributor Author

Hi @ryanvade thanks for the feedback
I removed the older one in order to remove the redundancy, since projectKey and projectKeys will solve same purpose. But I got your point. I will add these changes, will also add this new feature in README.

@kamesh-09
Copy link
Contributor Author

Removed the breaking changes and added new test cases around the projectKeys. Also, updated the README. If anything missing, please add.

@ryanvade ryanvade merged commit ca20147 into ryanvade:main Mar 10, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants