Skip to content

Conversation

@birkskyum
Copy link
Contributor

@birkskyum birkskyum commented Oct 23, 2025

For streaming ssr in tanstack start, I've found we need to allow passing in the custom serval plugins that are used with tanstack router. Otherwise there's a mismatch

@birkskyum birkskyum changed the title Custom plugins Custom seroval plugins Oct 23, 2025
@lxsmnsyc
Copy link
Collaborator

We need to overhaul the entirety of the serialization API. seroval is currently being used separately by Solid and SolidStart, which brings two issues (version parity and plugin parity). We want dom-expressions to expose a serialization API so that SolidStart doesn't have to independently use seroval on its own and while also keeping the plugin capability the same.

@birkskyum
Copy link
Contributor Author

birkskyum commented Oct 24, 2025

That sounds like a good idea. It also sounds like a breaking change - where this PR makes things work for now in a non-breaking way. I'd prefer if we can land this first, to remove any urgency, and then make a larger refactor later. @ryansolid would it be okay with you to do it in that order?

@ryansolid
Copy link
Owner

I'm ok with that. It is just an added API so it won't break anything else.

@lxsmnsyc How should this work for something like TanstackStart? I get that SolidStart wants to share the serializer obviously, but it is an interesting question should others as well.

@lxsmnsyc
Copy link
Collaborator

@ryansolid well Tanstack will still suffer from the duped seroval since they use seroval independently.

@birkskyum
Copy link
Contributor Author

birkskyum commented Oct 26, 2025

Right, this pr isn't about performance, but rather adding flexibility to make some errors go away, so that we can move tanstack start forward. If it opens the door to a shared serializer afterwards, that would be cool, but it's not a requirement for a first version of start.

@birkskyum
Copy link
Contributor Author

since you both have expressed to be ok with this non-breaking tweak, then I'd love to land it, so that we can proceed building out the ssr story for start.

@ryansolid
Copy link
Owner

So we are ok with this going out with a patch release of Solid.. 1.9.10 effectively.. that's ok?

@birkskyum
Copy link
Contributor Author

birkskyum commented Oct 27, 2025

Yes, that would be great

@birkskyum
Copy link
Contributor Author

birkskyum commented Oct 27, 2025

added unit tests

@ryansolid ryansolid merged commit e8bcabc into ryansolid:main Oct 27, 2025
2 checks passed
@ryansolid
Copy link
Owner

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants