-
Notifications
You must be signed in to change notification settings - Fork 145
Custom seroval plugins #464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We need to overhaul the entirety of the serialization API. seroval is currently being used separately by Solid and SolidStart, which brings two issues (version parity and plugin parity). We want dom-expressions to expose a serialization API so that SolidStart doesn't have to independently use seroval on its own and while also keeping the plugin capability the same. |
|
That sounds like a good idea. It also sounds like a breaking change - where this PR makes things work for now in a non-breaking way. I'd prefer if we can land this first, to remove any urgency, and then make a larger refactor later. @ryansolid would it be okay with you to do it in that order? |
|
I'm ok with that. It is just an added API so it won't break anything else. @lxsmnsyc How should this work for something like TanstackStart? I get that SolidStart wants to share the serializer obviously, but it is an interesting question should others as well. |
|
@ryansolid well Tanstack will still suffer from the duped seroval since they use seroval independently. |
|
Right, this pr isn't about performance, but rather adding flexibility to make some errors go away, so that we can move tanstack start forward. If it opens the door to a shared serializer afterwards, that would be cool, but it's not a requirement for a first version of start. |
|
since you both have expressed to be ok with this non-breaking tweak, then I'd love to land it, so that we can proceed building out the ssr story for start. |
|
So we are ok with this going out with a patch release of Solid.. 1.9.10 effectively.. that's ok? |
|
Yes, that would be great |
41968fc to
7c32021
Compare
7c32021 to
8bbd80b
Compare
|
added unit tests |
|
Thanks |
For streaming ssr in tanstack start, I've found we need to allow passing in the custom serval plugins that are used with tanstack router. Otherwise there's a mismatch