Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to solidjs/solid#2339
ssr: namespaced attributes are inlined into the html in some situations
With config option
ssr:true
sometimes(depending on if<Dynamic ../>
JSX tag was used or not) the namespaced attributes are being written to the html.For example
<div attr:name="value"/>
produces the same thing, instead of<div name="value"/>
Investigating, it seems that
attr:
wasn't the only special namespace with problems. This PR includes updates for avoiding inlining ofprop/attr/bool:
namespaces.prop/attr:
works in both cases for my tests (dynamic or not)There's a need to look into
ssrAttribute
because for some reasonbool:
ends inlined when used as<div bool:name="quack"/>
(this doesn't happen when used as<Dynamic component="div" bool:name.../>
). I have looked but didn't feel confident enough to include the namespace in thessrAttribute
call, to fix it there.I'm fine with merging this as is for now