Use fontforge 2022 #884
Merged
Use fontforge 2022 #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] Fontforge 2020 March or 20th Anniversary have problems to generate fonts with a lot of table entries. This is for example the massive entries for ligatures in Iosevka. We can not generate valid font files with that fontforge versions. We can not even detect (from Python side) if fontforge had problems. [how] We fixed fontforge itself upstream with fontforge/fontforge#4883 That fix became available first with Fontforge March 2022 Release. We could use the AppImage or build from scratch, because no package is available on Ubuntu 20.04 or 22.04. Signed-off-by: Fini Jastrow <[email protected]>
[why] * Automatically does a shallow checkout, what we want anyhow * Keep up to date Signed-off-by: Fini Jastrow <[email protected]>
Signed-off-by: Fini Jastrow <[email protected]>
[why] The purged (obsolete) files are still existing after release. [how] We restore the deleted files before it adds the new ones. Just delete all font files and then download all the release files (all newly created fonts). `git add` on a directory will remove all missing files. Signed-off-by: Fini Jastrow <[email protected]>
[why] It might be easier to use the precompiled application than to build it ourselves. [how] The AppImage has the typical problem with relative paths, so we need to change some small calls. Signed-off-by: Fini Jastrow <[email protected]>
[why] The new 'pathname' pattern always added a '*' glob to the end. So when we wanted to (just) recreate "Inconsolata" (by specifying "/Inconsolata") that means "/Inconsolata*/*.[to]tf". But that includes also "IncolsolataGo" and "InconsolataLCG" :-( [how] Just remove the globbing after the pathname. If a pathname is specified it must be the correct pathname and no star is added per default. Users could still specify "/Incon*" to get all Inconsolatas in the pathname based filter mode.
This was referenced Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the problems with Iosevka.
The reason for the problems has been fixed here:
fontforge/fontforge#4883
And is available with March 2022 Release of
fontforgeRequirements / Checklist
What does this Pull Request (PR) do?
How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
#694
obsoletes #750
Screenshots (if appropriate or helpful)
This PR also contains some CI fixes to get release 2.2.0 running.