-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icons for Emacs and Orgmode #833
Conversation
Technical remark: @ryanoasis I do not see how the Additionally there is at least one glyph in On the other hand P.S. Oh man is font-custom old :-> |
I think the orgmode svg is needlessly detailed (and thus big in file size). Maybe it can be simplified? Just a gut feeling. |
Ah, and ... thanks for the contrib :-) |
Good idea! I managed to reduce the size of orgmode using SVGO. (from 16.2 KiB to 5.5 KiB) Also I updated Let me know if I miss something. :) |
😸 I actually optimized SVGs before filing this PR. But there is a
I think that's manual. |
It's the other way around. This repo should aim to assemble all its parts from the basic building blocks (in this case the |
Any update here? |
Who is 'you'? :-) I dont even know what orgmode is. |
You = the author of the PR. The merged version is the full-detail outline, but as I think of nerd-font being used at smaller sizes I wonder if a simplified form would be more appropriate. When re-doing the website (https://orgmode.org) last year, I created a range of detail levels of the logo. The reduced-detail version I shared above is now used in the file-icons package as of file-icons/icons#88. |
Thanks! |
Cool. If you do whip up a PR from this, you'll probably be most interested in file-icons' optimised path version: https://raw.githubusercontent.com/file-icons/icons/master/svg/Org-Mode.svg. |
[why] The glyph is needlessly detailed (for a font). There is another, more simple glyph, which is also used by fileicons. More details see PR #833. Reported-by: tecosaur <[email protected]> Signed-off-by: Fini Jastrow <[email protected]>
Want to have a look before I merge? Great job with the simplified icon, btw 👍 Edit: Add where it looks a bit wide, the SVG is just a copy, but I scaled it up in ff |
[why] The glyph is needlessly detailed (for a font). There is another, more simple glyph, which is also used by fileicons. More details see PR #833. Reported-by: tecosaur <[email protected]> Signed-off-by: Fini Jastrow <[email protected]>
[why] The glyph is needlessly detailed (for a font). There is another, more simple glyph, which is also used by fileicons. More details see PR #833. Reported-by: tecosaur <[email protected]> Signed-off-by: Fini Jastrow <[email protected]>
Add icons for Emacs and Orgmode
Description
Add icons for Emacs and Orgmode.
Requirements / Checklist
What does this Pull Request (PR) do?
I used Inkscape to edit the SVG files, then imported them into Fontforge. In the meanwhile, I uploaded the SVG files to IcoMoon to see if they triggered any warnings. And add them to
original-source.otf
ase532
ande533
. Also, I updatefont-patcher
to include new icons in patched fonts.How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Closes #342
Similar PR #429
Screenshots (if appropriate or helpful)
Changes in
original-source.otf
Patched font:
Nvim with patched font:
Let me know if I miss something.
Thanks!