-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
font info: Remove references to 'Terminess' from non-Terminus fonts #724
Conversation
[why] In some fonts, on in the `patched-fonts/` directory the font information files contain an explanation why the font is called "Terminess" and not "Termius" - but the font is neither. Affected: DroidSansMono and Ubuntu (non mono) I assume this is a 'I copied the info file over from an existing font and just change the names' (but the source was unfortunately Terminess). [how] Manually remove the paragraph from all files that contain it which but have another name altogether. [note] Not shure if they are autogenerated somehow, with for example `standardize-and-complete-readmes.sh` ... but a `git grep` showed only the files that are changed with this PR. Signed-off-by: Fini Jastrow <[email protected]>
Hello! Grammar?! Word order? 😞 |
Hmm,
I do not really / exactly know what Rules for |
It looks like somewhere/somehow a few fonts haven't had their specific readme updated by the script (DroidSansMono also seems to be incorrect).
Agree Cascadia should have it. I tried to put a basic description at the top of the script. basically tries to compile a standard readme from all the various possible variations a font's readme might be in and also adds a few extra bits like the RFN info and common FAQ.
You mean for the reserved font name right? It was there previously but has been removed because Fira's RFN clause was removed |
Ah, wow! 👍 What puzzles me is that |
yeah so I found an issue there with FiraMono which still does have an RFN. I.e. FiraMono has the RFN but FiraCode does not. That is my understanding at least... I pushed up some fixes either way |
Description
[why]
In some fonts, on in the
patched-fonts/
directory the font informationfiles contain an explanation why the font is called "Terminess" and not
"Termius" - but the font is neither.
Affected:
DroidSansMono
andUbuntu
(non mono)I assume this is a 'I copied the info file over from an existing font
and just change the names' (but the source was unfortunately Terminess).
[how]
Manually remove the paragraph from all files that contain it which but
have another name altogether.
[note]
Not shure if they are autogenerated somehow, with for example
standardize-and-complete-readmes.sh
... but agit grep
showed onlythe files that are changed with this PR.
Requirements / Checklist
Scripts execute without error (if necessary):./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
./gotta-patch-em-all-font-patcher\!.sh Hermit
What does this Pull Request (PR) do?
Remove wrong paragraph from font info
*.md
files.How should this be manually tested?
Look on web pages in the branch, patched fonts, Ubuntu.
Direct link
Any background context you can provide?
While I fetched
Ubuntu
to try it out on Windows with Panose.What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)
Edit: Add direct link to changed web page(s)