Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

font info: Remove references to 'Terminess' from non-Terminus fonts #724

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

Finii
Copy link
Collaborator

@Finii Finii commented Dec 18, 2021

Description

[why]
In some fonts, on in the patched-fonts/ directory the font information
files contain an explanation why the font is called "Terminess" and not
"Termius" - but the font is neither.

Affected: DroidSansMono and Ubuntu (non mono)

I assume this is a 'I copied the info file over from an existing font
and just change the names' (but the source was unfortunately Terminess).

[how]
Manually remove the paragraph from all files that contain it which but
have another name altogether.

[note]
Not shure if they are autogenerated somehow, with for example
standardize-and-complete-readmes.sh ... but a git grep showed only
the files that are changed with this PR.

Requirements / Checklist

  • Read the Contributing Guidelines
  • Read or at least glanced at the FAQ
  • Read or at least glanced at the Wiki
  • Scripts execute without error (if necessary):
    • If any of the scripts were modified they have been tested and execute without error, e.g.:
      • ./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
      • ./gotta-patch-em-all-font-patcher\!.sh Hermit
  • Extended the README and documentation if necessary, e.g. You added a new font please update the table

What does this Pull Request (PR) do?

Remove wrong paragraph from font info *.md files.

How should this be manually tested?

Look on web pages in the branch, patched fonts, Ubuntu.
Direct link

Any background context you can provide?

While I fetched Ubuntu to try it out on Windows with Panose.

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

image

Edit: Add direct link to changed web page(s)

[why]
In some fonts, on in the `patched-fonts/` directory the font information
files contain an explanation why the font is called "Terminess" and not
"Termius" - but the font is neither.

Affected: DroidSansMono and Ubuntu (non mono)

I assume this is a 'I copied the info file over from an existing font
and just change the names' (but the source was unfortunately Terminess).

[how]
Manually remove the paragraph from all files that contain it which but
have another name altogether.

[note]
Not shure if they are autogenerated somehow, with for example
`standardize-and-complete-readmes.sh` ... but a `git grep` showed only
the files that are changed with this PR.

Signed-off-by: Fini Jastrow <[email protected]>
@Finii
Copy link
Collaborator Author

Finii commented Dec 18, 2021

Manually remove the paragraph from all files that contain it which but have another name altogether.

Hello! Grammar?! Word order? 😞

@Finii
Copy link
Collaborator Author

Finii commented Dec 18, 2021

Hmm,

$ git grep config_rfn_substitue

bin/scripts/standardize-and-complete-readmes.sh:  local config_rfn_substitue=$1; shift
bin/scripts/standardize-and-complete-readmes.sh:  if [ "$config_rfn" ] && [ "$config_rfn_substitue" ]
bin/scripts/standardize-and-complete-readmes.sh:      printf "\\n## Why \`%s\` and not \`%s\`?\\n" "$config_rfn_substitue" "$config_rfn"
bin/scripts/standardize-and-complete-readmes.sh:      unset config_rfn_substitue
bin/scripts/standardize-and-complete-readmes.sh:      appendRfnInfo "$config_rfn" "$config_rfn_substitue" "$PWD" "$to"
bin/scripts/standardize-and-complete-readmes.sh:      appendRfnInfo "$config_rfn" "$config_rfn_substitue" "$PWD" "$to"
bin/scripts/standardize-and-complete-readmes.sh:      appendRfnInfo "$config_rfn" "$config_rfn_substitue" "$PWD" "$to"
bin/scripts/standardize-and-complete-readmes.sh:    appendRfnInfo "$config_rfn" "$config_rfn_substitue" "$PWD" "$to"
src/unpatched-fonts/FiraMono/config.cfg:config_rfn_substitue=Fura
src/unpatched-fonts/Hasklig/config.cfg:config_rfn_substitue=Hasklug
src/unpatched-fonts/Hermit/config.cfg:config_rfn_substitue=Hurmit
src/unpatched-fonts/IBMPlexMono/config.cfg:config_rfn_substitue=Blex
src/unpatched-fonts/LiberationMono/config.cfg:config_rfn_substitue=Literation
src/unpatched-fonts/ShareTechMono/config.cfg:config_rfn_substitue=Shure
src/unpatched-fonts/SourceCodePro/config.cfg:config_rfn_substitue=Sauce
src/unpatched-fonts/Terminus/config.cfg:config_rfn_substitue=Terminess
src/unpatched-fonts/iA-Writer/config.cfg:config_rfn_substitue="iM Writing"
$

I do not really / exactly know what s&c-readmes does, but this looks like something would be needed for Cascadia.

Rules for Fira/Fura seem to be missing from font-patcher.
Rules for Anka/Coder exist in font-patcher but we don't have the font (which is ok).

@ryanoasis
Copy link
Owner

It looks like somewhere/somehow a few fonts haven't had their specific readme updated by the script (DroidSansMono also seems to be incorrect).

I do not really / exactly know what s&c-readmes does, but this looks like something would be needed for Cascadia.

Agree Cascadia should have it. I tried to put a basic description at the top of the script. basically tries to compile a standard readme from all the various possible variations a font's readme might be in and also adds a few extra bits like the RFN info and common FAQ.

Rules for Fira/Fura seem to be missing from font-patcher.

You mean for the reserved font name right? It was there previously but has been removed because Fira's RFN clause was removed

@ryanoasis ryanoasis merged commit 1344d0a into master Dec 20, 2021
@ryanoasis ryanoasis deleted the bugfix/markdown-contains-terminess branch December 20, 2021 01:57
ryanoasis added a commit that referenced this pull request Dec 20, 2021
@Finii
Copy link
Collaborator Author

Finii commented Dec 20, 2021

Fira's RFN clause was removed

Ah, wow! 👍

What puzzles me is that patched_fonts/FiraMono/ (still) contains Fura Mono Nerd Font, but that name is already in the source fonts, so ;-) Just mentioning in case that it is not intended.

@ryanoasis
Copy link
Owner

yeah so I found an issue there with FiraMono which still does have an RFN. I.e. FiraMono has the RFN but FiraCode does not. That is my understanding at least... I pushed up some fixes either way

LNKLEO pushed a commit to LNKLEO/Nerd that referenced this pull request Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants