Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for codicons #705

Merged
merged 2 commits into from
Dec 22, 2021
Merged

add support for codicons #705

merged 2 commits into from
Dec 22, 2021

Conversation

cstrahan
Copy link

@cstrahan cstrahan commented Dec 4, 2021

Description

Add support for codicons (https://github.com/microsoft/vscode-codicons).

@all-contributors please add @cstrahan for code

Requirements / Checklist

  • Read the Contributing Guidelines
  • Read or at least glanced at the FAQ
  • Read or at least glanced at the Wiki
  • Scripts execute without error (if necessary):
    • If any of the scripts were modified they have been tested and execute without error, e.g.:
      • ./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
      • ./gotta-patch-em-all-font-patcher\!.sh Hermit
  • Extended the README and documentation if necessary, e.g. You added a new font please update the table

What does this Pull Request (PR) do?

Add support for codicons (https://github.com/microsoft/vscode-codicons).

How should this be manually tested?

Perhaps. I have tested this in the gedit text editor as well as within neovim (from gnome-terminal) using the configuration here: https://github.com/onsails/lspkind-nvim

Any background context you can provide?

These are the same glyphs used by VSCode for Language Server icons (e.g. Enum, Member, Class, etc).

What are the relevant tickets (if any)?

Closes #620

Screenshots (if appropriate or helpful)

Screenshot from 2021-12-04 16-53-27

@cstrahan
Copy link
Author

cstrahan commented Dec 4, 2021

I'll note here that codicon.ttf is licensed under CC BY 4.0:

@cstrahan
Copy link
Author

cstrahan commented Dec 4, 2021

And the symbol start/end code points were taken from here: https://raw.githubusercontent.com/microsoft/vscode-codicons/main/dist/codicon.csv

@ryanoasis
Copy link
Owner

This is great. I'll check it out

@ryanoasis
Copy link
Owner

Could you move it into a sub directory and also drop the license file in the same folder?

I made a similar recent change here: 9633b4d

@ryanoasis ryanoasis merged commit f2b52fa into ryanoasis:master Dec 22, 2021
@ryanoasis
Copy link
Owner

@all-contributors please add @cstrahan for code

@allcontributors
Copy link
Contributor

@ryanoasis

I've put up a pull request to add @cstrahan! 🎉

@Finii Finii mentioned this pull request Sep 11, 2022
2 tasks
LNKLEO pushed a commit to LNKLEO/Nerd that referenced this pull request Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Codocons' glyphs
2 participants