Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fira Code to latest version #704

Merged
merged 6 commits into from
Dec 12, 2021
Merged

Conversation

gitfool
Copy link
Contributor

@gitfool gitfool commented Dec 4, 2021

Description

Updates Fira Code to latest version (v6.2). Fixes #697.

Requirements / Checklist

  • Read the Contributing Guidelines
  • Read or at least glanced at the FAQ
  • Read or at least glanced at the Wiki
  • Scripts execute without error (if necessary):
fontforge -script font-patcher src/unpatched-fonts/FiraCode/Bold/FiraCode-Bold.ttf
rm 'Fira Code Bold Nerd Font.ttf'

pushd bin/scripts
./standardize-and-complete-readmes.sh FiraCode
rm ../../patched-fonts/FiraCode/extras/font-info.md
./gotta-patch-em-all-font-patcher\!.sh FiraCode

popd
zip -9 FiraCode -rj patched-fonts/FiraCode -i '*.[o,t]tf'
  • Extended the README and documentation if necessary, e.g. You added a new font please update the table

What does this Pull Request (PR) do?

Updates Fira Code to latest version (v6.2).

How should this be manually tested?

Install the font and try it in your favorite editor. I'm already using it in VS Code and Windows Terminal.

FiraCode.zip

Any background context you can provide?

What are the relevant tickets (if any)?

#697

Screenshots (if appropriate or helpful)

@gitfool
Copy link
Contributor Author

gitfool commented Dec 4, 2021

@ryanoasis PTAL

@musm
Copy link

musm commented Dec 6, 2021

I don't think the mono flag is correctly set. VS Code terminal is complaining that the font is not monospaced.

@gitfool
Copy link
Contributor Author

gitfool commented Dec 6, 2021

@musm https://github.com/tonsky/FiraCode/releases/tag/6.2 💥

I'll pull the changes and regenerate tonight...

@gitfool
Copy link
Contributor Author

gitfool commented Dec 6, 2021

@musm re-download the zip and let me know how it goes...

@ryanoasis
Copy link
Owner

Thanks! I'll take a look "soon"

@musm
Copy link

musm commented Dec 7, 2021

@gitfool Thank you, works perfectly now.

@ryanoasis ryanoasis merged commit d72b772 into ryanoasis:master Dec 12, 2021
@gitfool gitfool deleted the gh697 branch December 12, 2021 03:22
LNKLEO pushed a commit to LNKLEO/Nerd that referenced this pull request Nov 24, 2023
Update Fira Code to latest version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Fira Code to version 6
3 participants