-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Symbols-2048-em Nerd Font Complete.ttf #609
Conversation
I just moved all the icons from Unicode Ranges used for Arabic, standard ligatures and other important sets to empty and clean F0000-FFFFF private set where is possible add more than 65,000 glyphs!
I changed just one file. I hope in the help of the community |
+1 |
Any updates on this PR? |
I see no objections to this PR, hoping it can be merged by end of May 2021?? Just in time for summer!! |
Well, I believe this MR has two points to be solved before it can be merged.
Because of 2 I believe the MR in its deceivingly simple logic (move See Issue #365 |
As a first step, could these symbols be duplicated in Arabic range and PUA? Then mark the Arabic range as deprecated in order to give time to the tools to migrate (one year?). Once done, we could just free the legacy Arabic range. |
Note possible interference with |
This is superseeded by Which will solve the PUA problems that we discussed in a lot of threads all over, in a different way than the one suggested with the PR (i.e. |
Thank you @fabrizioschiavi for the PR, as it was part of the solution finding process! 👍 |
Description
I just moved all the icons from Unicode Ranges used for Arabic, standard ligatures and other important sets to empty and clean F0000-FFFFD private set where is possible add more than 65,000 glyphs!
The positioning consider the actual codepoint, (e.g. E001 was changed to F0001) to limited the renaming process with the changes of some prefixes
Requirements / Checklist
./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
./gotta-patch-em-all-font-patcher\!.sh Hermit
What does this Pull Request (PR) do?
Avoid conflicts with the necessary glyphs of complete typefaces
How should this be manually tested?
Opening the changed ttf file
Any background context you can provide?
This is an important and necessary change because complete fonts like PragmataPro can be include all the glyphs possible without conflicts with very useful Nerd Font icons. Please don't ignore this request, it's important for all.
What are the relevant tickets (if any)?
#346
Screenshots (if appropriate or helpful)
Actual:
After pull request: