Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Symbols-2048-em Nerd Font Complete.ttf #609

Closed

Conversation

fabrizioschiavi
Copy link
Collaborator

Description

I just moved all the icons from Unicode Ranges used for Arabic, standard ligatures and other important sets to empty and clean F0000-FFFFD private set where is possible add more than 65,000 glyphs!
The positioning consider the actual codepoint, (e.g. E001 was changed to F0001) to limited the renaming process with the changes of some prefixes

Requirements / Checklist

  • [v] Read the Contributing Guidelines
  • Read or at least glanced at the FAQ
  • Read or at least glanced at the Wiki
  • Scripts execute without error (if necessary):
    • If any of the scripts were modified they have been tested and execute without error, e.g.:
      • ./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
      • ./gotta-patch-em-all-font-patcher\!.sh Hermit
  • Extended the README and documentation if necessary, e.g. You added a new font please update the table

What does this Pull Request (PR) do?

Avoid conflicts with the necessary glyphs of complete typefaces

How should this be manually tested?

Opening the changed ttf file

Any background context you can provide?

This is an important and necessary change because complete fonts like PragmataPro can be include all the glyphs possible without conflicts with very useful Nerd Font icons. Please don't ignore this request, it's important for all.

What are the relevant tickets (if any)?

#346

Screenshots (if appropriate or helpful)

Actual:
before

After pull request:
after

I just moved all the icons from Unicode Ranges used for Arabic, standard ligatures and other important sets to empty and clean F0000-FFFFF private set where is possible add more than 65,000 glyphs!
@polyzen
Copy link
Contributor

polyzen commented Apr 14, 2021

I believe you're meant to edit the 1000-em and 2048-em template files that are used in generating the complete symbols font files.

@fabrizioschiavi
Copy link
Collaborator Author

I changed just one file. I hope in the help of the community

@andrew-t-james-hm
Copy link

+1

@TerminalFi
Copy link

Any updates on this PR?

@andrew-hm
Copy link

I see no objections to this PR, hoping it can be merged by end of May 2021?? Just in time for summer!!

@Finii
Copy link
Collaborator

Finii commented Nov 25, 2021

Well, I believe this MR has two points to be solved before it can be merged.

  1. The technical ascpect is far from complete here. As @polyzen already pointed out it does not really help to patch some font file. What about all the patched fonts? Shall they not follow the new codepoints? This also means changes in the font-patcher.

  2. With this all powerline setups will break. People need to update their prompts; programs that show icons need to be recompiled, powerline templates have to be updated, ... etc pp. The list is endless.

Because of 2 I believe the MR in its deceivingly simple logic (move uE000 to uF0000) will not come. I personally would not want that. Albeit there is a problem with some (only a few) symbols we add that are outside the private areas. Probably they and only they will be shifted ... somewhen.

See Issue #365

@wismill
Copy link

wismill commented Nov 25, 2021

As a first step, could these symbols be duplicated in Arabic range and PUA? Then mark the Arabic range as deprecated in order to give time to the tools to migrate (one year?). Once done, we could just free the legacy Arabic range.

@Finii
Copy link
Collaborator

Finii commented Aug 22, 2022

Note possible interference with

@Finii
Copy link
Collaborator

Finii commented Sep 23, 2022

This is superseeded by

Which will solve the PUA problems that we discussed in a lot of threads all over, in a different way than the one suggested with the PR (i.e. Plan 5).

@Finii Finii closed this Sep 23, 2022
@Finii
Copy link
Collaborator

Finii commented Sep 23, 2022

Thank you @fabrizioschiavi for the PR, as it was part of the solution finding process! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants