Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ps installer #570

Merged
merged 5 commits into from
Aug 30, 2021
Merged

Fix ps installer #570

merged 5 commits into from
Aug 30, 2021

Conversation

fsackur
Copy link
Contributor

@fsackur fsackur commented Jan 27, 2021

Description

Please explain the changes you made here.

Requirements / Checklist

  • Read the Contributing Guidelines
  • Read or at least glanced at the FAQ
  • Read or at least glanced at the Wiki
  • Scripts execute without error (if necessary):
    • If any of the scripts were modified they have been tested and execute without error, e.g.:
      • ./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
      • ./gotta-patch-em-all-font-patcher\!.sh Hermit
  • Extended the README and documentation if necessary, e.g. You added a new font please update the table

What does this Pull Request (PR) do?

Fixes Powershell install script for Windows

How should this be manually tested?

  • Be on Windows
  • ./install.ps1 Hack

Any background context you can provide?

What are the relevant tickets (if any)?

#569
Possibly, #410
Related: #357

Screenshots (if appropriate or helpful)

  • VS Code settings.json contains "terminal.integrated.fontFamily": "MesloLGM NF, Hack NF"
  • Powerline theme works:
    image

@fsackur
Copy link
Contributor Author

fsackur commented Jan 27, 2021

I would appreciate guidance on the best way to update the readmes in the languages other than English - just Google Translate? There's not a lot of text, obvs!

@ryanoasis
Copy link
Owner

Really appreciate this!

I would appreciate guidance on the best way to update the readmes in the languages other than English

Honestly not sure. I think we've relied heavily on the community to submit PRs for readme translations.

I do use Google translate only for sanity spot checking the translations when I review them.

Happy to hear any other advice on this from anyone 😄

Copy link
Owner

@ryanoasis ryanoasis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix, documenting, and moving

@ryanoasis ryanoasis merged commit 8941467 into ryanoasis:master Aug 30, 2021
@Finii Finii mentioned this pull request Jan 28, 2023
LNKLEO pushed a commit to LNKLEO/Nerd that referenced this pull request Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants