Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed European Portuguese and Spanish translations errors #446

Merged
merged 5 commits into from
Mar 5, 2020
Merged

Fixed European Portuguese and Spanish translations errors #446

merged 5 commits into from
Mar 5, 2020

Conversation

gusbemacbe
Copy link
Contributor

@gusbemacbe gusbemacbe commented Feb 25, 2020

Description

Fixing the European Portuguese and Spanish translations errors.

Requirements / Checklist

  • Read the Contributing Guidelines
  • Read or at least glanced at the FAQ
  • Read or at least glanced at the Wiki
  • Scripts execute without error (if necessary):
    • If any of the scripts were modified they have been tested and execute without error, e.g.:
      • ./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
      • ./gotta-patch-em-all-font-patcher\!.sh Hermit
  • Extended the README and documentation if necessary, e.g. You added a new font please update the table

What does this Pull Request (PR) do?

Fixing the European Portuguese and Spanish errors.

European Portuguese

  • Fixed many European Portuguese translation errors;
  • Fixed grammar errors;
  • Fixed orthography errors;
  • Purged the Brazilian words, replacing with pure European Portuguese words;
  • Fixed wrong references (links) that @LiTO773 forgot of fixing.

Renamed the file, using the correct LCID code.

Spanish

  • Fixed quiero error, replacing with quieres;
  • Replaced "parámetro script" with "parámetro -script".

@gusbemacbe
Copy link
Contributor Author

@ryanoasis

Ready!

@LiTO773
Copy link
Contributor

LiTO773 commented Feb 25, 2020

Thanks for the help with the translation of the pt-pt file. I've been extremely busy lately and sadly couldn't fix the changes myself. I've reviewed your file and the translation seems correct.

However, DO NOT use the old AO in the pt-pt file. The current AO is how the pt-pt language is written and has already been adopted and enforced in the country.

(the most of people from Portugal rejected the new AO agreement) is a biased argument and couldn't be further from the truth.

If you want to use the old AO please create a pt-br README, since it is still in use in Brazil.

@gusbemacbe
Copy link
Contributor Author

Hello @LiTO773 !

I have talked with a native Portuguese, he suggested me to use the new AO. I have just reverted to the new AO. In spite of it, Público.pt, ironically Jornal de Notícias and many people still use the old AO.

If you want to use the old AO please create a pt-br README, since it is still in use in Brazil.

It is already enforced in the whole country, in spite of many people opposing the new AO.

@ryanoasis
Copy link
Owner

I am not much help here but did scan through it.

If you are both good with the changes I'll merge it!

Thanks!

@gusbemacbe
Copy link
Contributor Author

Hey @LiTO773, where are you? We need your approval.

@LiTO773
Copy link
Contributor

LiTO773 commented Mar 5, 2020

LGTM

Just change parámetro to parâmetro, since that's the correct spelling (only noticed now sry).

Everything else is great 👏

@gusbemacbe
Copy link
Contributor Author

@LiTO773, done.

@ryanoasis, done. @LiTO773 approved.

@ryanoasis
Copy link
Owner

Thanks

@ryanoasis ryanoasis merged commit 908c880 into ryanoasis:master Mar 5, 2020
@ryanoasis ryanoasis added this to the v2.2.0 milestone Mar 5, 2020
LNKLEO pushed a commit to LNKLEO/Nerd that referenced this pull request Nov 24, 2023
Fixed European Portuguese and Spanish translations errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants