Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #412 #439

Merged
merged 1 commit into from
Feb 22, 2020
Merged

Fix #412 #439

merged 1 commit into from
Feb 22, 2020

Conversation

onokatio
Copy link
Contributor

Description

Fix #412. sourceFont.fullname and sourceFont.version is None when the source font uses CID format.
So this use .cidfontname instead of .fullname. also .version to .cidversion.

Requirements / Checklist

  • Read the Contributing Guidelines
  • Read or at least glanced at the FAQ
  • Read or at least glanced at the Wiki
  • Scripts execute without error (if necessary):
    • If any of the scripts were modified they have been tested and execute without error, e.g.:
      • ./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
      • ./gotta-patch-em-all-font-patcher\!.sh Hermit
  • Extended the README and documentation if necessary, e.g. You added a new font please update the table

What does this Pull Request (PR) do?

use .cidfontname instead of .fullname. also .version to .cidversion.

How should this be manually tested?

./font-patcher ~/Downloads/SourceHanMono-Regular.otf --powersymbols -ext otf

Any background context you can provide?

What are the relevant tickets (if any)?

#412

Screenshots (if appropriate or helpful)

use cid object instead of native.
@onokatio onokatio requested a review from ryanoasis February 12, 2020 04:36
@ryanoasis
Copy link
Owner

I think this makes sense, let's try it :) thanks.

@ryanoasis ryanoasis added this to the v2.2.0 milestone Feb 22, 2020
@ryanoasis ryanoasis merged commit 36d0708 into ryanoasis:master Feb 22, 2020
@onokatio onokatio deleted the fix-postscript-cid branch March 8, 2020 15:54
LNKLEO pushed a commit to LNKLEO/Nerd that referenced this pull request Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Font patcher error with Noto Sans CJK
2 participants