Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #412.
sourceFont.fullname
andsourceFont.version
isNone
when the source font uses CID format.So this use
.cidfontname
instead of.fullname
. also.version
to.cidversion
.Requirements / Checklist
./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
./gotta-patch-em-all-font-patcher\!.sh Hermit
Extended the README and documentation if necessary, e.g. You added a new font please update the tableWhat does this Pull Request (PR) do?
use
.cidfontname
instead of.fullname
. also.version
to.cidversion
.How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
#412
Screenshots (if appropriate or helpful)