Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fantasque Sans Mono to 1.8.0 #423

Merged
merged 1 commit into from
Jan 19, 2020

Conversation

adzenith
Copy link
Contributor

Description

This updates Fantasque Sans Mono to the newest version, which has ligature support. (Changelog)

Requirements / Checklist

  • Read the Contributing Guidelines
  • Read or at least glanced at the FAQ
  • Read or at least glanced at the Wiki
  • Scripts execute without error (if necessary):
    • If any of the scripts were modified (None were modified) they have been tested and execute without error, e.g.:
      • ./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
      • ./gotta-patch-em-all-font-patcher\!.sh Hermit
  • Extended the README and documentation if necessary, e.g. You added a new font please update the table (Nothing was updated)

Aside: would it be interesting to show the font version in the README table so it's easy to tell which are up to date?

What does this Pull Request (PR) do?

Updates Fantasque Sans Mono to 1.8.0.
I updated the src/unpatched-fonts, as well as the license (copyright year update) and the readme, then ran the script to update everything.

How should this be manually tested?

I installed the fonts on my Mac and they seem to work. Interestingly I did see one error with the italic variant:
Screen Shot 2020-01-17 at 16 41 23
But the font still appears to work fine.

Any background context you can provide?

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

Regular:
image

Italic:
image

Bold:
image

Bold Italic:
image

@adzenith adzenith changed the title Update unpatched Fantasque Sans Mono to 1.8.0 Update Fantasque Sans Mono to 1.8.0 Jan 17, 2020
@ryanoasis
Copy link
Owner

Thanks @adzenith looks good at a glance, will review tomorrow

@ryanoasis ryanoasis merged commit 25eec39 into ryanoasis:master Jan 19, 2020
@adzenith
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants