Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InconsolataLGC font #205

Merged
merged 1 commit into from
Oct 27, 2017
Merged

Conversation

iloginow
Copy link
Contributor

Description

Adds InconsolataLGC (Latin, Greek, Cyrillic) font.

Inconsolata is one of the most suitable fonts for programmers created by Raph
Levien. Since the original Inconsolata does not contain Cyrillic alphabet,
it was slightly inconvenient for not a few programmers from Russia.

Inconsolata LGC is a modified version of Inconsolata with added the Cyrillic
alphabet which directly descends from Inconsolata Hellenic supporting modern
Greek.

Requirements / Checklist

  • Read the Contributing Guidelines
  • Read or at least glanced at the FAQ
  • Read or at least glanced at the Wiki
  • Scripts execute without error (if necessary):
    • If any of the scripts were modified they have been tested and execute without error, e.g.:
      • ./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
      • ./gotta-patch-em-all-font-patcher\!.sh Hermit
  • Extended the README and documentation if necessary, e.g. You added a new font please update the table

What does this Pull Request (PR) do?

Adds InconsolataLGC (Latin, Greek, Cyrillic) font.

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

gscreenshot_2017-10-19-132023

@iloginow
Copy link
Contributor Author

@ryanoasis
Regarding the 'left arrow' issue: I tested some more fonts and none of them got this ugly 'left arrow' gap. So conclusion by exclusion: the problem is somehow the InconsolataGo font itself.

@ryanoasis
Copy link
Owner

@iloginow

Hey thanks for the new PR. I am guessing it is due to my comment here #197 (comment) ?

Thanks for testing more fonts and narrowing it down to the InconsolataGo itself. This is very helpful! Really appreciate it 😄

That's strange, hopefully we can get to a solution.

I have been a bit delayed lately but I will get your PR and others merged in somewhat soon.

Thanks for the patience

@ryanoasis ryanoasis merged commit 72e82cc into ryanoasis:master Oct 27, 2017
@ryanoasis ryanoasis added this to the v1.2.0 milestone Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants