Repository navigation
Conversation
Contributor
Author
|
I borked a force push from a shallow clone, so this PR died. Resubmitted as #1926. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For icons with the
pastretch rule,font_patchercurrently scales icons up to fit the cell in monospace patching, but only scales down for non-monospace. This makes some icons significantly smaller with non-monospaced patching than with monospaced, which is rather unexpected. Case in point: thend-md-alphaalphabetic icons are tiny in non-monospaced fonts, but substantial in monospaced.With this PR, non-monospaced patching never makes smaller icons than monospaced. For
pa, if monospaced patching would scale up, non-monospaced scales up by the same amount, but no more.Requirements / Checklist
Issue number where discussion took place: #xxx
What does this Pull Request (PR) do?
iconheightout into a separate function that takes an optionalsingle_widthparametersingle_widthwhen neededpaicons that don't need downscaling, sets the scale factor to the maximum of 1 and the single width scale factor.How should this be manually tested?
(nd-md-alpha_z)in both variants at the same font sizeAny background context you can provide?
See explanation.
What are the relevant tickets (if any)?
NA.
Screenshots (if appropriate or helpful)
See above.