Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upstream Gohufont bug #1654

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Fix upstream Gohufont bug #1654

merged 2 commits into from
Jun 18, 2024

Conversation

Finii
Copy link
Collaborator

@Finii Finii commented Jun 11, 2024

Description

Separate the question mark and the inverted question mark in Gohufont 14.
They have the same glyph name in that font file and the wrong one is usually used.
The other becomes inaccessible.

See report in koemaeda/gohufont-ttf#3

Here we fix the source font file directly.

Requirements / Checklist

  • Read the Contributing Guidelines
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan.
    Issue number where discussion took place: #xxx
  • If this contains a font/glyph add its origin as background info below (e.g. URL)
  • Verified the license of any newly added font, glyph, or glyph set. License is: xxx

What does this Pull Request (PR) do?

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

Fixes: #1652

Screenshots (if appropriate or helpful)

Sorry, something went wrong.

Finii added 2 commits June 11, 2024 22:24
[why]
Ordinary questionmark and inverted questionmark in upstream Gohufont 14
have the same glyph name, breaking the font.

[how]
Rename the inverted questionmark to the customary "inverted" via ttx.

This just prepares the change.

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Also clean up README situation.

Fixes: #1652

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii Finii added the Bug fix label Jun 11, 2024
@Finii
Copy link
Collaborator Author

Finii commented Jun 11, 2024

Need to check the bitmaps before merging.

@Finii
Copy link
Collaborator Author

Finii commented Jun 18, 2024

Bitmaps are ok after PR.

image

In fontforge, View, enable bitmap at bottom

image

@Finii Finii merged commit a4ddd1e into master Jun 18, 2024
1 check passed
@Finii Finii deleted the bugfix/Gohufont branch June 18, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GohuFont question mark is upside-down
1 participant