Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Correct name for AnonymicePro Nerd Font #1385

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

kingarrrt
Copy link
Contributor

Description

The AnonymicePro Nerd Font is incorrectly named Anonymice Nerd Font.

Requirements / Checklist

What does this Pull Request (PR) do?

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

@Finii
Copy link
Collaborator

Finii commented Oct 17, 2023

Good catch!

Thanks for the PR!

Hmm, I see more strangenesses...:

image

Some have Nerd Font in the listed name, and some dont. 🤔

Also checked fonts.json, but there AnonymicePro is correct.

@Finii
Copy link
Collaborator

Finii commented Oct 17, 2023

@allcontributors please add @kingarrrt for doc

@allcontributors
Copy link
Contributor

@Finii

I've put up a pull request to add @kingarrrt! 🎉

@Finii Finii merged commit e0fa68b into ryanoasis:master Oct 17, 2023
@Finii
Copy link
Collaborator

Finii commented Oct 17, 2023

Maybe you like to comment on this...:

image

I would drop the Win-Linux-Mac indicators, the table would get vertically condensed - and the indicators are defunct anyhow.

Then we should unify the naming, add - or remove - the Nerd Font part from the patched font names (column 1)?

The column names (column 1 and 2) are also rather ... similar Font Name and Font Name and Repo...
Maybe change first column header to Patched Font Name?

@kingarrrt
Copy link
Contributor Author

Yes re defunct Win-Linux-Mac indicators.

It looks like the Patched Fonts table could be generated from fonts.json and the fonts' README.md files to ensure correctness.

@Finii
Copy link
Collaborator

Finii commented Oct 19, 2023

could be generated from fonts.json

Excellent idea! 👍

(Except at least ProFont which has more than one entry in the table because of different versions. Hmm, I seem to remember that there are other fonts also with a variety of versions. But that is just a detail.)

I would even put the version information into fonts.json. We could reuse that information for nerdfonts.com then.

Are you interested in implementing something? Otherwise I would code something up.

@kingarrrt
Copy link
Contributor Author

Very sorry, I don't have bandwidth to implement.

@kingarrrt kingarrrt deleted the kingarrrt-patch-1 branch October 19, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants