Ubuntu: Fix wrong Condensed classification #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] The Ubuntu Condensed font is special because it is designed to be not part of the `Ubuntu` font family but a self standing `Ubuntu Condensed` family with just one member. We want the `Ubuntu Condensed` to be part of `Ubuntu`, as it is usual for fonts with different widths. The problem then arises that the width class in the font metadata is set to 'Normal', while it has to be 'Condensed'. That fact does not become apparent when the font is in its own one member family, but even there it is wrong. [how] To keep all the other information in the font untouched we just directly patch that one byte where the width-class is stored - and repair the checksums afterwards. Nothing more. The code to do this is the Font Tweaker code in font-patcher, just copied here for one time use. Fixes: #1228 Signed-off-by: Fini Jastrow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[why]
The Ubuntu Condensed font is special because it is designed to be not part of the
Ubuntufont family but a self standingUbuntu Condensedfamily with just one member.We want the
Ubuntu Condensedto be part ofUbuntu, as it is usual for fonts with different widths.The problem then arises that the width class in the font metadata is set to 'Normal', while it has to be 'Condensed'. That fact does not become apparent when the font is in its own one member family, but even there it is wrong.
[how]
To keep all the other information in the font untouched we just directly patch that one byte where the width-class is stored - and repair the checksums afterwards. Nothing more.
The code to do this is the Font Tweaker code in font-patcher, just copied here for one time use.
Fixes: #1228
Requirements / Checklist
What does this Pull Request (PR) do?
How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)