Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add glyph for fennel #1129

Merged
merged 2 commits into from
Nov 11, 2023
Merged

Add glyph for fennel #1129

merged 2 commits into from
Nov 11, 2023

Conversation

Grazfather
Copy link
Contributor

Description

Fennel is a popular lisp-like lang that compiles to Lua. See fennel-lang.org.

The logo is CC-BY-SA 4.0.

Attached is a monochrome svg by @m455 (+thanks to @eccentric-j for converting to monochrome), but I can look into converting it properly using IcoMoon.

Requirements / Checklist

What does this Pull Request (PR) do?

Adds a single glyph for the fennel-lang logo

How should this be manually tested?

Verify glyph shows up in patched fonts

Any background context you can provide?

What are the relevant tickets (if any)?

See bakpakin/Fennel#438

Screenshots (if appropriate or helpful)

@Grazfather
Copy link
Contributor Author

Is anything else needed on my end, or is it just a waiting game until a bunch of changes are batched up for a new release?

@Finii
Copy link
Collaborator

Finii commented Mar 18, 2023

/me working hard to get overdue v3.0.0 ready with all that is already 'in'

@Grazfather
Copy link
Contributor Author

Right on! No rush, I just wanted to make sure you weren't waiting on me. Thank you!

@Grazfather
Copy link
Contributor Author

Anything I can do to help get this included in the next release?

@Finii
Copy link
Collaborator

Finii commented Nov 11, 2023

Thanks for the PR! Sorry for the long wait.

Small problem, overlapping path not handled correctly, fixing...

image

@Finii Finii added this to the v3.1.0 milestone Nov 11, 2023
[why]
Fonts can only work with paths. The svg has strokes and objects that
render incorrect.

[how]
Convert everything to path than combine all paths.

Signed-off-by: Fini Jastrow <[email protected]>
@Finii
Copy link
Collaborator

Finii commented Nov 11, 2023

Rebase on master, force push.

@Finii Finii merged commit 68283f0 into ryanoasis:master Nov 11, 2023
1 check was pending
@Finii
Copy link
Collaborator

Finii commented Nov 11, 2023

@allcontributors please add @Grazfather for code or design or whatever ;)

Copy link
Contributor

@Finii

I've put up a pull request to add @Grazfather! 🎉

@Grazfather Grazfather deleted the add_fennel branch November 12, 2023 02:44
@Grazfather
Copy link
Contributor Author

Whoa! Thank you, and sorry for the trouble with the SVG. Thanks for fixing it for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants