Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark old MDI as obsolete on cheat sheet #1097

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

Finii
Copy link
Collaborator

@Finii Finii commented Feb 1, 2023

[why]
The (old) Material Design Icons are to be removed. We should communicate that on the Cheat Sheet.

[how]
See commit
4452cee Add possibility to add "obsolete" to glyphs

that implements the CSS stuff to display an 'obsolete' marker.

Change the cheat-sheet generatot to actually insert the markers for the appropriate codepoints. That is, the codepoints are not checked but the ID.

Fixes: #1096

Requirements / Checklist

What does this Pull Request (PR) do?

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

Before:

image

After:

image

[why]
The (old) Material Design Icons are to be removed.
We should communicate that on the Cheat Sheet.

[how]
See commit
  4452cee  Add possibility to add "obsolete" to glyphs

that implements the CSS stuff to display an 'obsolete' marker.

Change the cheat-sheet generatot to actually insert the markers for the
appropriate codepoints. That is, the codepoints are not checked but the
ID.

Fixes: #1096

Signed-off-by: Fini Jastrow <[email protected]>
@Finii Finii merged commit 660aa80 into master Feb 1, 2023
@Finii Finii deleted the feature/obsolete-on-cheat-sheet branch February 1, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Label deprecated icons on cheat sheet
1 participant