Do not destroy ligs or SS #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] When a certain 'higher codepoint' glyph is needed for a substitution or ligature rule of a basic glyph and we replace the 'higher codepoint' glyph with a symbol that stylistic set or ligature will be broken. [how] We can not determine if a certain glyph is the _target_ of a pos-sub rule (at least I could not find a way). What we do is remove all pos-sub entries that _start_ at a symbol-patched glyph [1], but that is not the same. Instead of walking through all substitution tables we just examine the 'basic glyphs' and also protect all glyphs that they reference through most of the possub tables. In fact I encountered only "Substitution" entries and never "Ligature" entries, but we handle both alike. "Pair", "AltSub", and "MultSub" are not handled, but could be added if need be. [1] #711 Fixes: #901 Reported-by: Xiangyu Zhu <[email protected]> Signed-off-by: Fini Jastrow <[email protected]>
|
|
|
Affected:
Looks good. Astonished noone ever reported Ubuntu! |
[why] When --quiet and --no-progressbar is given we get a lot of empty lines in the output. [how] Just output the carriage return when we have output som eunterminated stuff before. Signed-off-by: Fini Jastrow <[email protected]>
This was referenced Jan 28, 2023
LNKLEO
pushed a commit
to LNKLEO/Nerd
that referenced
this pull request
Nov 24, 2023
…stic-sets Do not destroy ligs or SS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[why]
When a certain 'higher codepoint' glyph is needed for a substitution or ligature rule of a basic glyph and we replace the 'higher codepoint' glyph with a symbol that stylistic set or ligature will be broken.
[how]
We can not determine if a certain glyph is the target of a pos-sub rule (at least I could not find a way). What we do is remove all pos-sub entries that start at a symbol-patched glyph [1], but that is not the same.
Instead of walking through all substitution tables we just examine the 'basic glyphs' and also protect all glyphs that they reference through most of the possub tables.
In fact I encountered only "Substitution" entries and never "Ligature" entries, but we handle both alike. "Pair", "AltSub", and "MultSub" are not handled, but could be added if need be.
[1] #711
Fixes: #901
Reported-by: Xiangyu Zhu [email protected]
Requirements / Checklist
What does this Pull Request (PR) do?
How should this be manually tested?
Check all fonts and collect data on which codepoints will be skipped.
Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)