Fix Iosevka Family names #1019
Merged
Fix Iosevka Family names #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] The Iosevka font has a lot of different families. A lot users install just all "Iosevka Nerd Font" families, and this can break in a lot different ways. I will try to collect Issues possibly caused by this in PR #1019. [how] Just turn the feature on in font-patcher (via patch-em-all's config). Signed-off-by: Fini Jastrow <[email protected]>
|
Possible phenotypes of the Family name issue: |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[why]
The Iosevka font has a lot of different families. A lot users install just all "Iosevka Nerd Font" families, and this can break in a lot different ways.
I will try to collect Issues possibly caused by this in PR #1019.
[how]
Just turn the feature on in
font-patcher(via patch-em-all's config).Requirements / Checklist
What does this Pull Request (PR) do?
Enable
--makegroupsfor Iosevka on release runs.How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)
For example in Gnome Terminal, this is how all the Iosevka Families are shown at the moment:
And this is after this PR has been pulled:
Note that the
Nerd Fontpart is missing in the 'now' screenshot :-o This not even breaks all the patched Iosevkas, because they mix up all families, but also interfere with parallel installed Iosevka-original :-(