font-patcher crashes when patching Agave

[ThoriumTextile]

🗹 Requirements

• A brief but descriptive title of your issue
• I have searched the issues for my issue and found nothing related and/or helpful
• I have read or scanned the FAQ
• I have read or scanned the Wiki

🎯 Subject of the issue

Whenever i try to patch (no output dir specified) Agave-Regular-slashed (from here), font-patcher crashes with the following details/log:
This happens with the regular Agave version (not slashed) too.

The following table(s) in the font have been ignored by FontForge
  Ignoring 'TTFA'
The requested file, original-source.otf, does not exist
Traceback (most recent call last):
  File "/home/gabri/Downloads/./font-patcher", line 929, in <module>
    main()
  File "/home/gabri/Downloads/./font-patcher", line 924, in main
    patcher.patch()
  File "/home/gabri/Downloads/./font-patcher", line 88, in patch
    symfont = fontforge.open(self.args.glyphdir + patch['Filename'])
OSError: Open failed

🔧 Your Setup

• Which font are you using (e.g. Anonymice Powerline Nerd Font Complete.ttf)?
• Agave
• Which terminal emulator are you using (e.g. iterm2, urxvt, gnome, konsole)?
• kitty
• Are you using OS X, Linux or Windows? And which specific version or distribution?
• Fedora 34, Linux

★ Optional

[ryanoasis]

were you using the font-patcher from this repo? If so how did you download it? It sounds like you are missing the source files that the patcher relies upon.

[NuraliMedeu]

Hello! I have the same issue when patching Kawkab Mono.

🗹 Requirements

• A brief but descriptive title of your issue
• I have searched the issues for my issue and found nothing related and/or helpful
• I have read or scanned the FAQ
• I have read or scanned the Wiki

🎯 Subject of the issue

The same as above.

🔧 Your Setup

• Which font are you using (e.g. Anonymice Powerline Nerd Font Complete.ttf)?
  Kawkab Mono
• Which terminal emulator are you using (e.g. iterm2, urxvt, gnome, konsole)?
  Windows Terminal v1.11.3471.0
• Are you using OS X, Linux or Windows? And which specific version or distribution?
  Windows 11 Pro 21H2 Build 22000.376
• How did you get font-patcher?
  I downloaded it from the Nerd Fonts website without any additional files from this repo.

[NuraliMedeu]

I just learned from reading other similar issues that the user needs to clone the entire repo for the font patcher to work. I think the script should automatically download its dependencies, rather than rely on the user to install them.

[Finii]

I believe we are going to split this into one repo with the patcher (and what it needs) and one with the fonts.
But even then is an automatism to fetch missing parts nice. At least when it is an option, because I know enough ppl that dislike downloads not manually triggered.

[NuraliMedeu]

I think it's more frustrating when you expect a script file to work on its own and then realize that you need to manually download extra files for it to function, than when the said script works standalone, even if that means it automatically downloads its dependencies. As long as the need for those automatic downloads is explicitly communicated to the user and the script gives an option for their installation path, I think most people will accept this.

The users will spend less time searching for related issues and more time using the script.

[Finii]

Hint has been added to font-patcher
Maybe use the prepared FontPatcher.zip from the release page?
Docker?

[github-actions]

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.