Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alien Icon (some Weather icons rather small) #1708

Closed
3 tasks done
vurtune opened this issue Sep 8, 2024 · 3 comments · Fixed by #1726
Closed
3 tasks done

Alien Icon (some Weather icons rather small) #1708

vurtune opened this issue Sep 8, 2024 · 3 comments · Fixed by #1726

Comments

@vurtune
Copy link

vurtune commented Sep 8, 2024

Requirements

  • I have searched the issues for my request and found nothing related or helpful
  • I have checked the FAQ for help
  • I have reviewed the Wiki for relevant information

Problem Description

Alien  (e36e) icon is too small on FiraCode Mono

Desired Solution

Can you make a little more bigger?
Like 󰢚 (f089a)

Alternatives Considered

No response

Additional Context

No response

@Finii
Copy link
Collaborator

Finii commented Sep 16, 2024

Screenshot 2024-09-16 at 08 07 57 Screenshot 2024-09-16 at 08 08 19

The icon looks different ;-)

Hmm, the weather "extra" icons are all so small, let me find out why

Screenshot 2024-09-16 at 08 11 21

The scaling code is this (the original icon codepoint is F075 so it falls into the last of all rules:

        WEATH_SCALE_LIST = {'ScaleGroups': [
            [0xf03c, 0xf042, 0xf045 ], # degree signs
            [0xf043, 0xf044, 0xf048, 0xf04b, 0xf04c, 0xf04d, 0xf057, 0xf058, 0xf087, 0xf088], # arrows
            range(0xf053, 0xf055 + 1), # thermometers
            [*range(0xf059, 0xf061 + 1), 0xf0b1], # wind directions
            range(0xf089, 0xf094 + 1), # clocks
            range(0xf095, 0xf0b0 + 1), # moon phases
            range(0xf0b7, 0xf0c3 + 1), # wind strengths
            [0xf06e, 0xf070 ], # solar/lunar eclipse
            # Note: Codepoints listed before that are also in the following range
            # will take the scaling of the previous group (the ScaleGroups are
            # searched through in definition order).
            # But be careful, the combined bounding box for the following group
            # _will_ include all glyphs in its definition: Make sure the exempt
            # glyphs from above are smaller (do not extend) the combined bounding
            # box of this range:
            range(0xf000, 0xf0cb + 1), # lots of clouds and other (Please read note above!)
        ]}

The original set looks like this

Screenshot 2024-09-16 at 08 15 41

Ok, thank you. I will do a search for the reasons ;-D

@Finii Finii changed the title Alien Icon Alien Icon (some Weather icons rather small) Sep 16, 2024
@Finii Finii added this to the v3.3.0 milestone Oct 28, 2024
@Finii
Copy link
Collaborator

Finii commented Oct 30, 2024

These are the scale groups visually

image

Note the orange brackets, that scale all not-marked glyphs between them (the lots of clouds and other group).

Clearly some icons do not belong in there, and maybe this is a new group:

image

Also noticed that one wind direction is not in the wind direction group 😬 (F0B1)

@Finii
Copy link
Collaborator

Finii commented Oct 30, 2024

Also noticed that one wind direction is not in the wind direction group 😬 (F0B1)

I'm sooo blind 😬

image

Finii added a commit that referenced this issue Oct 30, 2024
[why]
A lot of icons that do not represent a 'weather state' but rather a
'weather event' are in the 'weather state' scaling group which scales
the icons waaaay down. This makes those icons almost unusable in stand
alone use cases.

[how]
Put all the extra icons into a new scaleing group that is defined before
the weather state scaling group and thus takes precedence.

Split the final scaling group to have some icons on individual scale.

Fixes: #1708

Signed-off-by: Fini Jastrow <[email protected]>
@Finii Finii closed this as completed in 25ee48c Oct 30, 2024
Finii added a commit that referenced this issue Nov 13, 2024
[why]
A lot of icons that do not represent a 'weather state' but rather a
'weather event' are in the 'weather state' scaling group which scales
the icons waaaay down. This makes those icons almost unusable in stand
alone use cases.

[how]
Put all the extra icons into a new scaling group that is defined before
the weather state scaling group and thus takes precedence.

Split the final scaling group to have some icons on individual scale.

Fixes: #1708

Signed-off-by: Fini Jastrow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants