Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icon request] Add ChucK logo please #1489

Closed
Finii opened this issue Jan 19, 2024 Discussed in #1479 · 5 comments · Fixed by #1740
Closed

[Icon request] Add ChucK logo please #1489

Finii opened this issue Jan 19, 2024 Discussed in #1479 · 5 comments · Fixed by #1740
Labels
❲+❳ add glyph to core set keep_unlocked Allow discuissions for extended time even after closing

Comments

@Finii
Copy link
Collaborator

Finii commented Jan 19, 2024

Discussed in #1479

Originally posted by gacallea January 10, 2024
Hi :)

As the title says, I would like to suggest the addition of an icon for Chuck.

Logo is here:
Chuck logo

If I had the skills I'd try to patch and contribute. I hope this can be implemented.

Please and thank you

EDIT1:

just in case, this is how I set it for the time being. Mostly posting for the extension and name:

[...]
    {
      "nvim-tree/nvim-web-devicons",
      opts = {
        override_by_extension = {
          ["ck"] = {
            icon = "󰧚",
            color = "#80ff00",
            name = "ChucK",
          },
        },
      },
    },
[...]
@Finii
Copy link
Collaborator Author

Finii commented Mar 24, 2024

Closing because transferred to #1095

@Finii Finii closed this as completed Mar 24, 2024
@Finii Finii removed this from the v3.2.0 milestone Apr 18, 2024
@Finii Finii added the keep_unlocked Allow discuissions for extended time even after closing label Apr 18, 2024
@andreacfromtheapp
Copy link

Hi @Finii :)

I was just checking the add chuck glyph status and I see it was removed from v3.2.0. I'd like to know if it will make it in the next one, please? No hurry/rush/pressure, just curious.

Please and thank you

@Finii
Copy link
Collaborator Author

Finii commented Apr 21, 2024

Sorry, I just lack any good system for adding glyphs to the core set. I mean, selecting which should go in. usually I try to avoid it and direct people to seem inclusion in upstream icon sets.
When doing 3.2.0 I had so many things to do and include, so on the glyph addition side I believe we just had old 'Ada' being added.
I guess I should start a more systematic approach.
But then, it is extremely hard to judge if an icon is 'important' or not.

And did I not do some more work? I remember having that icon in the editor ...

Ah, there are two Issues for the same thing 😬

Ah, 1479 is a discussion and therefor not suited for 'serious work'.

Anyhow, I saw now some issues with the border, I guess that made me not-include it, because the outline was not 'clean', and manual cleanup takes some time that I could not find.

Copying the comments here:

SVG is here, quickly done using Inkscape and the original png image:

chuck

Maybe the square-brackets top and bottom are a bit thin?

image

and

Looks unclean:

image

@andreacfromtheapp
Copy link

Hi @Finii

all fair points. What you suggest I should do? Open an issue with another repo? I vaguely recall you saying that asking more upstream could be a better idea.

Also: this was my initial request #1479 the rest of discussions (this included) you opened yourself. :D

Please and thank you

@Finii
Copy link
Collaborator Author

Finii commented Apr 22, 2024

Tried to come up with some solution to the add-an-icon problem.
You can see the other candidates and some meaningless metrics in the Issue linked above.

Finii added a commit that referenced this issue Nov 17, 2024
Hand drawn in Inkscape.

Fixes: #1489

Signed-off-by: Fini Jastrow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❲+❳ add glyph to core set keep_unlocked Allow discuissions for extended time even after closing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants