Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monaspice look always bold #1433

Closed
Finii opened this issue Nov 21, 2023 · 18 comments
Closed

Monaspice look always bold #1433

Finii opened this issue Nov 21, 2023 · 18 comments

Comments

@Finii
Copy link
Collaborator

Finii commented Nov 21, 2023

Is it just me or does Monaspice look like it's always emboldened?

(Monaspice on the left with FiraCode for comparison):

VSCodium_2023-11-21_21-35-04 VSCodium_2023-11-21_21-35-49

I downloaded Monaspice via the scoop-nerd-fonts Scoop bucket. Haven't used the official non-patched Monaspace so I can't say if this is expected.

The Monaspice font used is MonaspiceNe NFM.

Originally posted by @redactedscribe in #1403 (comment)

@redactedscribe
Copy link

@Finii Thanks for moving the issue.

@Finii
Copy link
Collaborator Author

Finii commented Nov 21, 2023

Sorry to hear of your problem.

For me it looks like your FiraCode is not Regular?

image

@Finii
Copy link
Collaborator Author

Finii commented Nov 21, 2023

I'm too stupid ...

image

@Finii
Copy link
Collaborator Author

Finii commented Nov 21, 2023

So yes, Monaspace Regular seams to be slightly heavier than FiraCode Regular.

@Finii Finii closed this as completed Nov 21, 2023
@redactedscribe
Copy link

I guess you mean to say that this is indeed expected. First impression was that it seems broken, but maybe this really is how it's supposed to look. I guess it's an issue with Monaspace itself.

@Finii
Copy link
Collaborator Author

Finii commented Nov 21, 2023

We patch these:

weights=(Regular Italic Bold BoldItalic Medium MediumItalic)

But there are also

  • ExtraLight
  • Light
  • SemiBold
  • ExtraBold

Maybe try the Light weight from https://github.com/githubnext/monaspace/tree/main/fonts/otf.
We could add a weight if there is demand.

@Finii
Copy link
Collaborator Author

Finii commented Nov 21, 2023

But of course using Light breaks the RIBBI set, I have no clue what your client uses for bold then, Bold? Not font at all but it does the bold face from the base face arithmetically? With some clients you can select 'normal' and 'embolded' font separately, then you could select Thin and Medium for ex.

@redactedscribe
Copy link

Using VS Codium with "editor.fontWeight": "normal". The values which change MonaspiceNe NFM's weight are 400, 500, 600 (or normal, medium, bold).

I just went through a bunch of other fonts to compare to and it seems Monaspace is just a heavier font by default.

Interestingly, it's also heavier compared to what https://monaspace.githubnext.com/ shows. Here are some screenshots comparing the font in VS Code (newly downloaded zip, only font changed) to the font as seen on the Monaspace site using Firefox.

Side-by-side:

Code_2023-11-21_22-51-57

Overlaid:

Code_2023-11-21_22-53-20

@redactedscribe
Copy link

redactedscribe commented Nov 21, 2023

Inspecting the @keyframes word using Firefox shows that they are using a font weight of 300. Strange to showcase your font with something other than the default?

firefox_2023-11-21_23-02-23

This is either indicative of some issue, or it's as simple as the web designer decided to use a lighter font weight for the showcase. Either way, I guess it helped give me the impression that the font was unusually heavy once installed.

@thewinger
Copy link

+1 to adding the Light weight to the font

@Finii
Copy link
Collaborator Author

Finii commented Nov 22, 2023 via email

@redactedscribe
Copy link

Ok, I ll add this now but will come only on next release. Can put the prepatched archive here if that helps?

I'd be interested to see the result.

Finii added a commit that referenced this issue Nov 22, 2023
Fixes: #1433

Signed-off-by: Fini Jastrow <[email protected]>
@Finii
Copy link
Collaborator Author

Finii commented Nov 22, 2023

Monaspace_only_Light.tar.xz.zip

This is just the Light and LightItalic fonts. Again xz packed because otherwise too big for a comment, afterwards zip packed because Github does not allow xz 🙄

@redactedscribe
Copy link

redactedscribe commented Nov 22, 2023

Thanks @Finii. It is less heavy, only marginally, but it is better. Here's MonaspiceNe NFM normal/400 in VS Codium compared to 300, and Consolas 400 on the far right (opening the images in separate tabs and switching between them helps):

VSCodium_2023-11-22_17-39-33 VSCodium_2023-11-22_17-31-10 VSCodium_2023-11-22_17-42-51

I think 200 (so ExtraLight) for Monaspice would be closest to most other monospace fonts I'm seeing at their regular font size of 400. I will test this now using Monaspace.

(Whilst comparing fonts, I've had to change font size +/- 2 to keep them roughly the same size, not sure how much of a role that plays in my tests. Maybe it would've been better to vary the line spacing instead.)

@Finii
Copy link
Collaborator Author

Finii commented Nov 22, 2023

I just wanted to mention that the weight unit (100-900) is arbitrary units. Although there are 'suggestions' it is not a measure in any way.

One person's fatal error is another person's most common case ;-)

@redactedscribe
Copy link

redactedscribe commented Nov 22, 2023

Hmm. Not that knowledgeable about fonts so this is the testing methodology I came up with.

With NF fonts I don't think we can specify something like MonaspiceNe NFM Light as the font instead of MonaspiceNe NFM so editing the font weight is the only way I know how. Whether 300 is exactly "Light", I'm not sure. Shouldn't have assumed that.

So, I just compared Monaspace Neon Light (official OTF) at 400 to MonaspiceNe NFM at 300 and they appear to be identical, so maybe the assumption worked out this time.

As for the official ExtraLight at normal/400, here is its result:

VSCodium_2023-11-22_18-03-04

To my eyes, this looks closest to what I'd expect Regular to be, although your patched NFM Light is quite close too, but still looks like it's more on the side of Bold than Regular. It's minor I guess.

@Finii
Copy link
Collaborator Author

Finii commented Nov 22, 2023

Just had to laugh so hard ;-)

LNKLEO pushed a commit to LNKLEO/Nerd that referenced this issue Nov 28, 2023
Fixes: ryanoasis#1433

Signed-off-by: Fini Jastrow <[email protected]>
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants