-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lilex fonts' "Thin" and "Bold" weights all are labeled "Normal", thus not installable next to the "Regular" weight #1333
Comments
Thanks for your response! Would it be ok to keep the issue open? I need to find time to figure out the details with the new awesome information you gave me. Maybe it's a bug in KDE's font viewer / fonts configuration app. I'd be curious to find out more and report in their bug tracker (linking to here) if that's the case. Do you happen to know / like to recommend a Linux app to view font detail properties like the label-pairs you've show in your screenshots? |
Shure, let it open. To examine font files
But they all just give you some name parts, and you need a understanding how they are to be used. Also worth to know that Nerd Fonts never sets ID21/22. It created RIBBI fonts sets in ID1/2 (of course) and the full style is only available in ID16/17. For ID1/2 the unrepresentable styles are represented via Family names instead. RIBBI means Regular-Italic-Bold-BoldItalic. That is the "classic set" for applications that have an "Italics" and "Bold" button for the selected font. Sometimes that applications automatically generate missing styles (creates an oblique version of a font with no Italic style by slanting the glyphs, with ... mixed results). What you maybe should examine is if the unpatched Lilex has the same problem. Its naming is about the same as the patched font, see |
Hi! Thanks for all the resources! I believe the issue is the very basic "Font Weight" value in "PS Names". Here's some good examples (Sauce/Source Code Pro Nerd Font):Extra LightRegular = BookSemiBold = DemiBoldHere's bad examples (Lilex)Lilex Bold showing as Book (= Normal)Lilex Thin showing as Book (= Normal)Lilex Bold and Thin have an incorrect weight value of "Book", which clashes with the actual Normal/Regular/Book weight font file. M+1 Code Thin and Extra Light both show as LightComparing with Source Code Pro Nerd Font Extra Light, it seems like the "PS Names" font weight ("Strichstärke") should be "Extra-Light". Both Thin and Extra Light use "Light", which clashes with the actual "Light" weight font file. |
You had mentioned I should investigate the original Lilex font. I downloaded Lilex.zip from https://github.com/mishamyrt/Lilex/releases/tag/2.200 from Apr 13. Other than in the NF version ("Book"), the original Lilex Bold font uses the correct PS font weight ("Bold"): The same is true for the Thin weight, which contains the wrong PS font weight value ("Book") in the NF version, but the correct value in the original font ("Thin"): -- The M+1 Code font appears to be broken Maybe Lilex had been broken when NF imported it, and was fixed in the mean time? Edit: M+1 Code ExtraLight from Google Fonts is broken, but the real upstream (according to the Google Fonts "about" page) appears to be https://github.com/coz-m/MPLUS_FONTS/blob/master/fonts/ttf/Mplus1Code-ExtraLight.ttf - which is correct: => Maybe old versions of Lilex and M+1 Code were broken, and the latest versions just need to be re-imported into the NerdFonts project? |
Thanks for the input, I will investigate (sorry for the delay) |
Apart from all the usual fixes and expansion in the source font the weight metadata has been fixed. Fixes: #1333 Reported-by: LeoniePhiline Signed-off-by: Fini Jastrow <[email protected]>
This is not in the 2.200 release, but we do not have |
They renamed M Plus Code Latin -> M Plus Code Latin50 M Plus Code Latin Expanded -> M Plus Code Latin60 The versioning is rather divers, add more information into the font specific README file. Fixes: #1333 Reported-by: LeoniePhiline Signed-off-by: Fini Jastrow <[email protected]>
[why] Windows seems to construct the font names including the PS weight. We have some sourcefonts that are broken (i.e. have in fact different weights but have the same PS weight and/or OS2 weight. That raises problems with the fonts on Windows. [how] Check and compare all weight metadata (except CID) and issue a warning if they differ too much. That might fail with unusual weight names, though. See Issue #1333 and PR #1358. Reported-by: LeoniePhiline Signed-off-by: Fini Jastrow <[email protected]>
Implemented a check for weight inconsistencies. There are quite some more, but Lilex was the worst: Thanks again for the thorough analysis here! |
@allcontributors please add @LeoniePhiline for bug |
I've put up a pull request to add @LeoniePhiline! 🎉 |
[why] Windows seems to construct the font names including the PS weight. We have some sourcefonts that are broken (i.e. have in fact different weights but have the same PS weight and/or OS2 weight. That raises problems with the fonts on Windows. [how] Check and compare all weight metadata (except CID) and issue a warning if they differ too much. That might fail with unusual weight names, though. See Issue #1333 and PR #1358. Reported-by: LeoniePhiline Signed-off-by: Fini Jastrow <[email protected]>
[why] Windows seems to construct the font names including the PS weight. We have some sourcefonts that are broken (i.e. have in fact different weights but have the same PS weight and/or OS2 weight. That raises problems with the fonts on Windows. [how] Check and compare all weight metadata (except CID) and issue a warning if they differ too much. That might fail with unusual weight names, though. See Issue #1333 and PR #1358. Reported-by: LeoniePhiline Signed-off-by: Fini Jastrow <[email protected]>
[why] Windows seems to construct the font names including the PS weight. We have some sourcefonts that are broken (i.e. have in fact different weights but have the same PS weight and/or OS2 weight. That raises problems with the fonts on Windows. [how] Check and compare all weight metadata (except CID) and issue a warning if they differ too much. That might fail with unusual weight names, though. See Issue ryanoasis#1333 and PR ryanoasis#1358. Reported-by: LeoniePhiline Signed-off-by: Fini Jastrow <[email protected]>
They renamed M Plus Code Latin -> M Plus Code Latin50 M Plus Code Latin Expanded -> M Plus Code Latin60 The versioning is rather divers, add more information into the font specific README file. Fixes: #1333 Reported-by: LeoniePhiline Signed-off-by: Fini Jastrow <[email protected]>
Apart from all the usual fixes and expansion in the source font the weight metadata has been fixed. Fixes: #1333 Reported-by: LeoniePhiline Signed-off-by: Fini Jastrow <[email protected]>
[why] Windows seems to construct the font names including the PS weight. We have some sourcefonts that are broken (i.e. have in fact different weights but have the same PS weight and/or OS2 weight. That raises problems with the fonts on Windows. [how] Check and compare all weight metadata (except CID) and issue a warning if they differ too much. That might fail with unusual weight names, though. See Issue ryanoasis#1333 and PR ryanoasis#1358. Reported-by: LeoniePhiline Signed-off-by: Fini Jastrow <[email protected]>
They renamed M Plus Code Latin -> M Plus Code Latin50 M Plus Code Latin Expanded -> M Plus Code Latin60 The versioning is rather divers, add more information into the font specific README file. Fixes: ryanoasis#1333 Reported-by: LeoniePhiline Signed-off-by: Fini Jastrow <[email protected]>
Apart from all the usual fixes and expansion in the source font the weight metadata has been fixed. Fixes: ryanoasis#1333 Reported-by: LeoniePhiline Signed-off-by: Fini Jastrow <[email protected]>
This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference. |
🗹 Requirements
🎯 Subject of the issue
Experienced behavior:
Lilex fonts' "Thin" and "Bold" weights all are labeled "Normal", thus not installable next to the "Regular" weight.
This applies to "Lilex", "Lilex Mono" and "Lilex Propo".
Expected behavior:
Each file should contain a font labelled with the according font weight. E.g. the File called "LilexNerdFont-Bold.ttf" should contain a font named "Lilex Nerd Font, Bold", not "Lilex Nerd Font, Normal".
Example symbols:
Not relevant
🔧 Your Setup
Anonymice Powerline Nerd Font Complete.ttf
)?iterm2
,urxvt
,gnome
,konsole
)?★ Screenshots (Optional)
Can't install "Bold" as it has the same internal font name as "Regular", namely "Normal":
Each weight needs its own name.
The text was updated successfully, but these errors were encountered: