Caskaydia Cove introduces ligature issue not in Cascadia Code #1291

Kissaki · 2023-06-06T16:42:27Z

Testing in Windows Terminal - font size 12, Windows 11, NF v3.0.2

I would expect the ligature for => to be the same and without visual artifacts.

Cascadia Code:

CaskaydiaCove Nerd Font Mono:

🗹 Requirements

I have searched the issues for my issue and found nothing related and/or helpful
I have searched the FAQ for help
I have searched the Wiki for help

The text was updated successfully, but these errors were encountered:

Finii · 2023-06-07T18:30:58Z

Oh, sorry to hear that. Lets find the reason.

Works in Writer

phjordan · 2023-06-08T07:52:14Z

I see the same, in Windows Terminal as well as in VS Code, Nerd Fonts 3.0.2

Finii · 2023-06-08T11:07:33Z

Can not reproduce on Win10, VS Code 1.71.0, NF 3.0.2:

My settings:

Finii · 2023-06-08T11:10:47Z

The problem with Windows Terminal is that they bundle Cascadia Cove (VF) with it and one can not uninstall it, which I hate.

Installing that thing now, hold tight.

Finii · 2023-06-08T11:14:40Z

@phjordan Btw, please share a picture of your config.json and maybe a view of the font settings dialog with 'cas' as search term:

You see I have no Cascadia Code installed. I unpacked the Caskaydia zip file, select all, right click, install (for user) (is how I installed the fonts).

Finii · 2023-06-08T11:22:36Z

Can see it with Windows Terminal:

(:thought_balloon: Now I can not restart VS Code, great)

Finii · 2023-06-08T11:47:38Z

Could not start VS Code
Revert changes in config.js - still not opening
Remove VS Code via 'apps'
Reinstall VS Code via MS Store - problem: can not install
Reboot
Reinstall VS Code via MS Store - problem: can not install
Download VS Code msi
Install - can not overwrite old files?
Reboot / manual deletion of old files
Install ok
Start ... still not opening

Windows is so easy, everything works out of the box!

phjordan · 2023-06-08T12:57:58Z

Here are my font settings, Both 'Cascadia Code' and 'CaskaydiaCove...' are installed for all users.

I noticed that the editor.fontSize-setting does have an effect. I don't know anything about font rendering and scaling, but maybe this observation is of help. With 'Cascadia Code' set as font, the arrows seem fine for all font sizes.

My original VS code settings.json:

It looks fine with editor.fontSize commented out:

It looks fine with font size 14:

Font size 12:

Font size 22:

Edit: This is on Windows 10

Finii · 2023-06-08T13:06:12Z

Thanks for the input! There are indeed size-limits where the font switches rendering, I will check that.
And maybe I can get VS Code repaired on that one machine, all other machines I have are Win11...

Edit: Ah, report was for Win 11 🤦‍♀️

Finii · 2023-06-08T15:09:09Z

Ah, I have another hunch...
Which concrete Cascadia Code did you compare with? (Best would be a details screenshot of the font settings thing, when opened Cascadia Code)?

I fear that it might be the hints 🙄

Finii · 2023-06-08T15:18:37Z

Which concrete Cascadia Code did you compare with?

This is the reason why I hate the bundling of Windows Terminal with Cascadia Cove, because they bundle the VF and one has to go through a lengthy operation to remove that if you want the otf or pure ttf ones instead.

The font-patcher can not work with VF, so we use some static ttf variant (see the readme)

phjordan · 2023-06-08T15:29:40Z

Which concrete Cascadia Code did you compare with? (Best would be a details screenshot of the font settings thing, when opened Cascadia Code)?

Yes, it seems to be the bundled version of Cascadia Code that I have installed.

FrancescoLuzzi · 2023-06-22T08:13:15Z

Thanks for the input! There are indeed size-limits where the font switches rendering, I will check that. And maybe I can get VS Code repaired on that one machine, all other machines I have are Win11...

Edit: Ah, report was for Win 11 🤦‍♀️

Also reproducible on windows 10 👍🏼

azdanov · 2023-06-28T04:37:29Z

I also encountered this issue. Windows 11, Windows Terminal 1.17

Can see that -- near git are of different sizes

And it gets better with font size increase.

harshv5094 · 2023-06-29T14:38:07Z

I've Installed the latest version of Caskaydia Cove NF on my windows 10, and now I'm seeing this box icons, I need help regarding this issue

Finii · 2023-06-29T16:38:27Z

@harshv1741 This is no ligature Issue.

Please check out

Some glyphs missing after v3.x.x update #1190 (comment)

[why] Some Caskaydia Cove glyphs that are used in ligatures (to create endless arrows for example) show uneven line thickness on some platforms. The reason is the not-matching hinting of glyphs that are places next to each other and so minuscule differences are quite visible. Note that the 'original' hinting is generated by VTT on the static Cascadia Code instances, which upstream just have ttfautohint hints that are different from the hints in the variable fonts and people complained that the look is different. [how] Add a new field to the config.json file that holds regexes of glyph names for glyphs that should be re-hinted by fontforge on patching time. In principle we could also implement that as an additional pre-step that needs to be manually done after running VTT on the static font files. I'm not sure which is better. Note that fontforge generates a lot of debug output because the hinting is not ideal - the global tables are kept and probably less compatible to fontforge's own hinting... But the results are good. Fixes: #1291 Fixes: #1609 Signed-off-by: Fini Jastrow <[email protected]>

Finii · 2024-04-18T15:04:30Z

I would need someone who can test the potential fix, good would be a thorough test like @phjordan with all the arrows.

[why] Some Caskaydia Cove glyphs that are used in ligatures (to create endless arrows for example) show uneven line thickness on some platforms. The reason is the not-matching hinting of glyphs that are places next to each other and so minuscule differences are quite visible. Note that the 'original' hinting is generated by VTT on the static Cascadia Code instances, which upstream just have ttfautohint hints that are different from the hints in the variable fonts and people complained that the look is different. [how] Add a new field to the config.json file that holds regexes of glyph names for glyphs that should be re-hinted by fontforge on patching time. In principle we could also implement that as an additional pre-step that needs to be manually done after running VTT on the static font files. I'm not sure which is better. Note that fontforge generates a lot of debug output because the hinting is not ideal - the global tables are kept and probably less compatible to fontforge's own hinting... But the results are good. Fixes: #1291 Fixes: #1609 Signed-off-by: Fini Jastrow <[email protected]>

[why] Some Caskaydia Cove glyphs that are used in ligatures (to create endless arrows for example) show uneven line thickness on some platforms. The reason is the not-matching hinting of glyphs that are places next to each other and so minuscule differences are quite visible. Note that the 'original' hinting is generated by VTT on the static Cascadia Code instances, which upstream just have ttfautohint hints that are different from the hints in the variable fonts and people complained that the look is different. [how] Add a new field to the config.cfg file that holds regexes of glyph names for glyphs that should be re-hinted by fontforge on patching time. In principle we could also implement that as an additional pre-step that needs to be manually done after running VTT on the static font files. I'm not sure which is better. Note that fontforge generates a lot of debug output because the hinting is not ideal - the global tables are kept and probably less compatible to fontforge's own hinting... But the results are good. Fixes: #1291 Fixes: #1609 Signed-off-by: Fini Jastrow <[email protected]>

Finii · 2024-04-20T20:36:01Z

It would be great if someone who sees the arrows problem can check this font:

CaskaydiaCove_arrows.zip Version 3.2.1-10

(Probably you need to uninstall the old Caskaydia first, then reboot, then install the font given in this comment.)

Without reports it is hard to see if this will fix it or not... Help needed.

FrancescoLuzzi · 2024-04-20T21:36:20Z

Thanks for the update, i'll give it a try as soon as I can!

FrancescoLuzzi · 2024-04-21T10:23:12Z

It seems to be 99.9% resolved!

In some font sizes the "=>" ligature has a really small defect (there is a really small gap between the "equal" sign and the "greater than" sign

This is the "correct" arrow on a different size:

Same thing with:

Finii · 2024-04-21T13:36:10Z

Hmm, this is maybe also a hinting problem, this is most visible at 12 pt / 96 dpi.

The advance width is 9.4 pixel, and so the last pixel is only filled less than half, so it is rendered half-grey.
Of course this will vary with the number of characters in front of it.

The situation is comparable with FiraCode unpatched:

Just here other sizes show that same problem.

Are you sure Cascadia Code unpatched does not have the same problem at some sizes? Maybe you can try.
I need to fire up Glyphs3 to examine it. Or was there not a tool on Linux to show the subpixel rendering of variable fonts on Linux 🤔

I can check, but I believe this is a principle problem that can not be solved without 'massive' manual intervention.

Affected are a high number of glyphs (the font-patcher reports it auto-adjusts 88 glyphs), so that would be quite some work to do, manually edit the hints to extend more to the outside.
Well, and famous FiraCode has the same, so why should we be better ;-)

FrancescoLuzzi · 2024-04-21T14:32:07Z

Are you sure Cascadia Code unpatched does not have the same problem at some sizes? Maybe you can try.

Just uninstalled Caskaydia Cove, rebooted and tried using Cascadia Code, the issue is still there

Well... your patch worked just fine, it seems that Cascadia Code is the problem now.
Thanks!

Finii · 2024-04-21T14:43:15Z

Thank you for testing all that stuff!
I will do some final tests with the PR (because it completely changes how the configuration works), and then merge the fix.

Finii · 2024-04-21T14:43:56Z

@allcontributors please add @FrancescoLuzzi for bug

allcontributors · 2024-04-21T14:44:05Z

@Finii

I've put up a pull request to add @FrancescoLuzzi! 🎉

[why] Some Caskaydia Cove glyphs that are used in ligatures (to create endless arrows for example) show uneven line thickness on some platforms. The reason is the not-matching hinting of glyphs that are places next to each other and so minuscule differences are quite visible. Note that the 'original' hinting is generated by VTT on the static Cascadia Code instances, which upstream just have ttfautohint hints that are different from the hints in the variable fonts and people complained that the look is different. [how] Add a new field to the config.cfg file that holds regexes of glyph names for glyphs that should be re-hinted by fontforge on patching time. In principle we could also implement that as an additional pre-step that needs to be manually done after running VTT on the static font files. I'm not sure which is better. Note that fontforge generates a lot of debug output because the hinting is not ideal - the global tables are kept and probably less compatible to fontforge's own hinting... But the results are good. Fixes: #1291 Fixes: #1609 Signed-off-by: Fini Jastrow <[email protected]>

nguyenlephuc2108 · 2024-07-25T12:11:21Z

Oh! == is don't work, or my computer have problem?

Phoenix- · 2024-09-03T15:37:27Z

Hi,
I've got exactly the same problem with -> and => ligatures. Actual on all font sizes and font weights, but severity differs from size to size.

Win11 22631.4037
NF 3.2.1
Screenshot is from Windows Fonts Manager, but actual for any text editor. Tried VS Code and Windows Terminal

feliperomero3 · 2024-09-07T19:07:15Z

Hi, first, thank you for this nerd font, I've been using for four years now.

I'm experiencing the same ligature 'tearing' issue as @Phoenix-

(screen capture below)

In the --> ligature the 'tearing' is barely noticiable

In the ==> ligature, the 'tearing' is much more noticiable

These are the fonts shown in the screen capture (screen capture below)

My versions

CaskaydiaCove NF: Version 2111.001; VTT 6.35;Nerd Fonts 3.2.1

Finii · 2024-09-08T11:41:46Z

The problem is the hinting.

Cascadia Code comes hand-hinted as VF (variable font).
Nerd Fonts can not (for the foreseeable future) patch VF.
Cascadia Code also comes as static variants but they are autohinted by ttfautohint.
Thus Cascadia Code VF and Cascadia Code static differs 'a lot' visible in the lettershapes
People complain that (especially) the small letters of Caskaydia Cove look different from Cascadia Code
- Which they do and dont. They look different from Cascadia Cove VF because Caskaydia Cove is based on Cascadia Code static
For most people the expected look is the one of Cascadia Code VF because it is preinstalled on Win (often)
Instead of ttfautohint we push the Cascadia Code static fonts through VTT which is also an autohinter, but with a look more closely to the hand hinted original
Except that VTT does not hint all glyphs the same
We patch that font; Caskaydia Cove is Cascadia Code static rehinted by VTT to have a look similar to Cascadia Code VF
Well, except what you noticed above, the special lig glyphs are not/differently hinted compared to each other, resulting in sub-pixel differences in the line positions, which are then rendered "on pixel off"

The possibilities here are:

Use Cascadia Code static with ttfautohint (which I assume do not have this problem, but not checked)
Hand-hint the problematic ligature glyphs
Rewrite font-patcher to patch VFs 😁

Then I obviously did something here with commit b2cf801 font-patcher: Allow to rehint some Cascadia glyphs
Ah, this is

font-patcher: Allow to rehint some Cascadia glyphs #1613

That has been merged mid April 2024, just after the v3.2.1 release:

So probably your problems will (mostly) go away after the next release, which is v3.3.0, which is scheduled to happen this month (#1705). So please be patient a bit more. The fix is not 100% perfect but at least better (see notes / feedback above).

Phoenix- · 2024-09-09T10:16:46Z

Thanks for the explanation and for your work. Great fonts :)

Finii added the confirmed label Jun 8, 2023

Finii mentioned this issue Apr 18, 2024

CaskaydiaCove Nerd Font -- "Arrow" Ligature #1609

Closed

Finii mentioned this issue Apr 18, 2024

font-patcher: Allow to rehint some Cascadia glyphs #1613

Merged

4 tasks

allcontributors bot mentioned this issue Apr 21, 2024

docs: add FrancescoLuzzi as a contributor for bug #1615

Merged

Finii closed this as completed in #1613 Apr 22, 2024

Finii added this to the v3.3.0 milestone Sep 8, 2024

Finii added the ⏳ pending rebuild ... label Sep 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Caskaydia Cove introduces ligature issue not in Cascadia Code #1291

Caskaydia Cove introduces ligature issue not in Cascadia Code #1291

Kissaki commented Jun 6, 2023

Finii commented Jun 7, 2023

phjordan commented Jun 8, 2023

Finii commented Jun 8, 2023

Finii commented Jun 8, 2023

Finii commented Jun 8, 2023

Finii commented Jun 8, 2023

Finii commented Jun 8, 2023

phjordan commented Jun 8, 2023 •

edited

Loading

Finii commented Jun 8, 2023 •

edited

Loading

Finii commented Jun 8, 2023

Finii commented Jun 8, 2023

phjordan commented Jun 8, 2023

FrancescoLuzzi commented Jun 22, 2023

azdanov commented Jun 28, 2023

harshv5094 commented Jun 29, 2023 •

edited

Loading

Finii commented Jun 29, 2023

Finii commented Apr 18, 2024

Finii commented Apr 20, 2024 •

edited

Loading

FrancescoLuzzi commented Apr 20, 2024

FrancescoLuzzi commented Apr 21, 2024 •

edited

Loading

Finii commented Apr 21, 2024

FrancescoLuzzi commented Apr 21, 2024 •

edited

Loading

Finii commented Apr 21, 2024

Finii commented Apr 21, 2024

allcontributors bot commented Apr 21, 2024

nguyenlephuc2108 commented Jul 25, 2024

Phoenix- commented Sep 3, 2024 •

edited

Loading

feliperomero3 commented Sep 7, 2024

Finii commented Sep 8, 2024

Phoenix- commented Sep 9, 2024

Caskaydia Cove introduces ligature issue not in Cascadia Code #1291

Caskaydia Cove introduces ligature issue not in Cascadia Code #1291

Comments

Kissaki commented Jun 6, 2023

🗹 Requirements

Finii commented Jun 7, 2023

phjordan commented Jun 8, 2023

Finii commented Jun 8, 2023

Finii commented Jun 8, 2023

Finii commented Jun 8, 2023

Finii commented Jun 8, 2023

Finii commented Jun 8, 2023

phjordan commented Jun 8, 2023 • edited Loading

Finii commented Jun 8, 2023 • edited Loading

Finii commented Jun 8, 2023

Finii commented Jun 8, 2023

phjordan commented Jun 8, 2023

FrancescoLuzzi commented Jun 22, 2023

azdanov commented Jun 28, 2023

harshv5094 commented Jun 29, 2023 • edited Loading

Finii commented Jun 29, 2023

Finii commented Apr 18, 2024

Finii commented Apr 20, 2024 • edited Loading

FrancescoLuzzi commented Apr 20, 2024

FrancescoLuzzi commented Apr 21, 2024 • edited Loading

Finii commented Apr 21, 2024

FrancescoLuzzi commented Apr 21, 2024 • edited Loading

Finii commented Apr 21, 2024

Finii commented Apr 21, 2024

allcontributors bot commented Apr 21, 2024

nguyenlephuc2108 commented Jul 25, 2024

Phoenix- commented Sep 3, 2024 • edited Loading

feliperomero3 commented Sep 7, 2024

Finii commented Sep 8, 2024

Phoenix- commented Sep 9, 2024

phjordan commented Jun 8, 2023 •

edited

Loading

Finii commented Jun 8, 2023 •

edited

Loading

harshv5094 commented Jun 29, 2023 •

edited

Loading

Finii commented Apr 20, 2024 •

edited

Loading

FrancescoLuzzi commented Apr 21, 2024 •

edited

Loading

FrancescoLuzzi commented Apr 21, 2024 •

edited

Loading

Phoenix- commented Sep 3, 2024 •

edited

Loading