-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support to multi-language and translating CORS post #8
Conversation
Hey @heitorfig–greatly appreciated! I'll review this PR shortly, sorry for not noticing it sooner! |
That was a bit longer than "shortly", apologies! Something I just realized is that GitHub Pages (which I use to host the site) only supports these plugins. Unfortunately Also, part of the reason I've been dragging my feet is that I'm trying to get a loose set of licenses together for this repo. Would the following be amenable to you as a contributor?
You're the first official contributor so it's only fitting you get to help shape the licensing! :) |
I see, I had no idea that Pages does not support other plugins. I took a look at this issue, there is a thread about adding a multilingual plugin to Pages, but I think they are stuck on finding the best/secure one. Perhaps, doing it manually, as you said, is the best approach for now. I'm going to take a look at this article, and see what I can do. About the licensing, sure, I don't know a lot about licenses, but I'm going to study about it, and of course I'll try to help with what I know. |
I appreciate it @heitorfig! Let me know if there's anything I can do to help - my schedule is a bit hectic between my job and writing the weekly posts, but I'd like to help you show your translation to the world! As mentioned, I'd be happy to create a new page for it in the interim, at a URL like |
Hey @heitorfig - finally had some time this morning to think through this a bit more. Take a look at this branch and let me know what you think. It's a bit of a hack, since we can't use |
Hi, @andryanmiller @heitorfig . If you are find a compromise, I want to make PR with russian translation. Should I do it like in new branch in _translation folder? |
Hey @kirill-galushko! That should work well for the time being - I'm going to make a couple addl. tweaks here but overall I think we're close to having a nice translation system! I'll help you iron out any kinks as they come up, and thanks for being willing to translate into Russian! |
Hey @heitorfig! Finally had a large enough block of time that I was able to move the website off of Github Pages onto AWS. Now that that's the case, I'll be tidying a few things up and then switching over to the new version with your translation. I'll ping you again here when it's complete! |
Hey @andryanmiller, sorry for not responding, I was working hard these last days planning my wedding. I wasn't able to check it out. But, good news then, I'll also find some time to translate the other posts. |
I'd like to contribute, I made an upgrade to the blog to support multi-languages and also translated the latest post to brazilian portuguese. I hope you liked it. It was a very helpful article.