Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #189 Respect base_url setting and serve content and assets #312

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

ryanlelek
Copy link
Owner

Solves #189

To test:

  • Clone repo
  • make start
  • Validate service on http://localhost:3000/
  • Edit example/config.default.js to base_url: '/mydocs',
  • Restart service
  • Validate service on http://localhost:3000/mydocs/
  • Stop service
  • Validate multi-host of service by running node example/multiple-instances.js
  • Validate service on http://localhost:3000/en/ and http://localhost:3000/es/
    ^ Note that the multiple-service script passes a nowrap setting to prevent a double-wrap, one from app/index.js and the other in the multiple-instances.js script itself, which would lead to http://localhost:3000/en/en/

@ryanlelek ryanlelek mentioned this pull request Jan 4, 2020
@ryanlelek ryanlelek merged commit 3a59b08 into master Sep 17, 2020
@ryanlelek ryanlelek deleted the 20200104-189-base-url branch September 27, 2020 01:41
@Vorsku Vorsku mentioned this pull request Dec 26, 2020
AnkushLambdatest pushed a commit to AnkushLambdatest/Raneto that referenced this pull request Jun 29, 2022
Fix: ryanlelek#189 Respect base_url setting and serve content and assets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant