Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed all C++ warnings #75

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed all C++ warnings #75

wants to merge 1 commit into from

Conversation

GregTalotta
Copy link

I ran static analysis tools on the C++ code. Then fixed all warnings.

@ryanhaining
Copy link
Owner

The comparisons are done intentionally, the minimum requirements for an iterator that works with ranged-for include operator!= but not operator== so I only rely on the former. The iteratoriterator tests are verifying that the given operators work predictably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GregTalotta @ryanhaining