Fixes reference type in product

Issue #88
ryanhaining · Aug 18, 2022 · 038a436 · 038a436
1 parent 5e8ddb3
commit 038a436
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/product.hpp b/product.hpp
@@ -98,7 +98,7 @@ class iter::impl::Productor {
     using value_type = TupleDeref<TupleTypeT>;
     using difference_type = std::ptrdiff_t;
     using pointer = value_type*;
-    using reference = value_type&;
+    using reference = value_type;
 
     IteratorTempl(IteratorTuple<TupleTypeT>&& iters,
         IteratorTuple<TupleTypeT>&& end_iters)
@@ -148,7 +148,7 @@ class iter::impl::Productor {
       return {(*std::get<Is>(iters_))...};
     }
 
-    auto operator-> () -> ArrowProxy<decltype(**this)> {
+    auto operator->() -> ArrowProxy<decltype(**this)> {
       return {**this};
     }
   };

diff --git a/test/test_product.cpp b/test/test_product.cpp
@@ -221,6 +221,7 @@ TEST_CASE("product: iterator meets requirements", "[product]") {
   std::string s{"abc"};
   auto c = product(s, s);
   REQUIRE(itertest::IsIterator<decltype(std::begin(c))>::value);
+  REQUIRE(itertest::ReferenceMatchesDeref<decltype(std::begin(c))>::value);
 }
 
 template <typename... Ts>