-
Notifications
You must be signed in to change notification settings - Fork 44
Move default getClientIp to use proxy-addr, just like express does. #63
base: master
Are you sure you want to change the base?
Conversation
@pdefreitas perhaps it would be good to republish as express-ipfilter2 ? since this is unmaintained? |
@baminteractive @coopman @nsbingham do you intend to maintain the package or could someone take ownership or at least be maintainer? |
@Casz I can republish this project as express-ipfilter2 tomorow. I don't think the current owner of the repo is active. |
@pdefreitas could you try ask NPM transferring ownership first 😅 |
@Casz thanks for sharing, I have contacted NPM and the NPM project owner. |
I followed up with @pdefreitas but just so every one knows, I left the company a while back so I haven't been able to administer this at all. I reached out to see if I can get the ownership transferred and will let you know what happens |
thanks for the update @ryanbillingsley 🙌 |
@pdefreitas @Casz as you may have noticed, the repo was transferred back to me. I will look at this PR as soon as I can this evening. I mentioned it on #61, but I do want to get that version in before pushing a new major version out so I will try and get that taken care of if it isn't already by the time I can get to it. |
Includes #61 which bumps lodash version to fix security issues. Typos fixed in the readme.
Removes allowedHeaders in favour of proxy-addr (to streamline with Express behind proxies).
For more info and discussion check issue #62