Autodetection of minimum and maximum sample rates #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase I will merge this. Not having hardcoded rates is preferred |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
In rtl_power.c, there are two #defines : MAXIMUM_RATE and MINIMUM_RATE
These values are hardcoded and good for various rtl-sdr dongles.
However, they may be inappropriate for other hardware which kind of defeats the purpose of using SoapySDR.
This simple pull-request/patch is about adding auto-detection of the minimum and maximum sample rates for the selected hardware, allowing the logic of the original rtl_power to select the proper tuning range using the right sampling rates for the hardware.