Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer the run id from Mint #91

Merged
merged 2 commits into from
May 3, 2024
Merged

Infer the run id from Mint #91

merged 2 commits into from
May 3, 2024

Conversation

kylekthompson
Copy link
Member

@kylekthompson kylekthompson commented May 2, 2024

Infer the run id from Mint

Copy link

github-actions bot commented May 2, 2024

Bigtest for 9dffd12 (run)

Benchmarks:

  • RSpec: 6.84% overhead
    • RSpec time: 17.7 seconds
    • ABQ time: 18.91 seconds
  • RSpec parallel, 10 runs: max 12.66% overhead
    • min 5.93% overhead
    • standard deviation: 2.42%
  • Jest: 3.83% overhead
    • Jest time: 19.809 seconds
    • ABQ time: 20.567 seconds

Fuzz result sizes:

  • PASSED

ayazhafiz
ayazhafiz previously approved these changes May 3, 2024
Comment on lines 241 to 242
// note: if you change this, change it in setup-abq, too
// https://github.com/rwx-research/setup-abq/blob/8c5044343fceef53b4efea83d64062f006bf6758/src/index.ts#L23-L28
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that you ran into this outdated comment.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I probably should remove this

Copy link

github-actions bot commented May 3, 2024

Bigtest for 3763223 (run)

Benchmarks:

  • RSpec: 6.56% overhead
    • RSpec time: 17.67 seconds
    • ABQ time: 18.83 seconds
  • RSpec parallel, 10 runs: max 14.49% overhead
    • min 6% overhead
    • standard deviation: 3.12%
  • Jest: 3.83% overhead
    • Jest time: 19.762 seconds
    • ABQ time: 20.518 seconds

Fuzz result sizes:

  • PASSED

@kylekthompson kylekthompson merged commit 234d0c9 into main May 3, 2024
17 checks passed
@kylekthompson kylekthompson deleted the kt/mint-support branch May 3, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants