Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the logging of results message sizes #89

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Fix the logging of results message sizes #89

merged 2 commits into from
Jan 17, 2024

Conversation

ayazhafiz
Copy link
Contributor

The shorthand syntax is insufficient in practice, we must spell the
fields out. Tested by running a queue locally.

The shorthand syntax is insufficient in practice, we must spell the
fields out. Tested by running a queue locally.
Copy link

Bigtest for 0e2e4ff (run)

Benchmarks:

  • RSpec: 7.70% overhead
    • RSpec time: 17.79 seconds
    • ABQ time: 19.16 seconds
  • RSpec parallel, 10 runs: max 13.27% overhead
    • min 5.34% overhead
    • standard deviation: 2.74%
  • Jest: 4.33% overhead
    • Jest time: 20.114 seconds
    • ABQ time: 20.985 seconds

Fuzz result sizes:

  • PASSED

@ayazhafiz ayazhafiz enabled auto-merge (squash) January 17, 2024 16:48
Copy link

Bigtest for 92be935 (run)

Benchmarks:

  • RSpec: 6.65% overhead
    • RSpec time: 17.74 seconds
    • ABQ time: 18.92 seconds
  • RSpec parallel, 10 runs: max 13.36% overhead
    • min 5.86% overhead
    • standard deviation: 2.88%
  • Jest: 3.79% overhead
    • Jest time: 19.925 seconds
    • ABQ time: 20.68 seconds

Fuzz result sizes:

  • PASSED

@ayazhafiz ayazhafiz merged commit c7f21d7 into main Jan 17, 2024
17 checks passed
@ayazhafiz ayazhafiz deleted the ayaz/fix-logs branch January 17, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants