Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sis_setup_directory: fix crash on broken input symlink #236

Merged
merged 1 commit into from
Feb 6, 2025
Merged

sis_setup_directory: fix crash on broken input symlink #236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sisyphus/job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ def _sis_setup_directory(self, force=False):
# I it would be possible to hit some cases where this could
# cause a collision sorry if you are really that unlucky...
link_name = os.path.join(self._sis_path(gs.JOB_INPUT), str(job_id).replace("/", "_"))
if not os.path.isdir(link_name):
if not os.path.exists(link_name) and not os.path.islink(link_name):
os.symlink(src=os.path.abspath(str(creator._sis_path())), dst=link_name, target_is_directory=True)

# export the actual job
Expand Down