Use the same GitHub access token for both release-it and lerna-changelog
#15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both release-it and lerna-changelog require a GitHub personal access token. Both read it from an environment variable but by default not using the same name. release-it defaults to `$GITHUB_TOKEN` while lerna-changelog defaults to `$GITHUB_AUTH`. It could only be customized for release-it. Therefore changing it to `$GITHUB_AUTH`. Also documents that this environment variable is required. It wasn't documented so far at all. Background information could be found here: - https://github.com/release-it/release-it/blob/master/docs/github-releases.md - https://github.com/lerna/lerna-changelog#github-token
jelhan
force-pushed
the
use-one-env-variable-for-github-access-token
branch
from
be803ad
to
439910e
Compare
jelhan
added a commit
to jelhan/ember-file-upload
that referenced
this pull request
Feb 27, 2020
jelhan
added a commit
to jelhan/ember-file-upload
that referenced
this pull request
Feb 27, 2020
jelhan
added a commit
to jelhan/ember-file-upload
that referenced
this pull request
Feb 28, 2020
hjdivad
approved these changes
Feb 28, 2020
jelhan
added a commit
to adopted-ember-addons/ember-file-upload
that referenced
this pull request
Feb 29, 2020
* yarn create rwjblue-release-it-setup * apply changes proposed upstream rwjblue/create-rwjblue-release-it-setup#15 * update changelog until last release
rwjblue
changed the title
release-it and lerna-changelog
rwjblue
added a commit
that referenced
this pull request
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both release-it and lerna-changelog require a GitHub personal access token. Both read it from an environment variable but by default not using the same name. release-it defaults to
$GITHUB_TOKENwhile lerna-changelog defaults to$GITHUB_AUTH. It could only be customized for release-it. Therefore changing it to$GITHUB_AUTH.Also documents that this environment variable is required. It wasn't documented so far at all.
Background information could be found here: