Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Jest property matchers to ensure dependabot updates pass. #106

Merged
merged 1 commit into from
Jun 29, 2020

Conversation

rwjblue
Copy link
Owner

@rwjblue rwjblue commented Jun 29, 2020

Without these changes, when Dependabot updates release-it, release-it-lerna-changelog, or release-it-yarn-workspaces the tests here would fail (due to the inline snapshots no longer matching).

This leverages property matchers to ensure the snapshot itself stays stable, even when updating those dependencies.

Fixes #94

Without these changes, when Dependabot updates `release-it`,
`release-it-lerna-changelog`, or `release-it-yarn-workspaces` the tests
here would fail (due to the inline snapshots no longer matching).

This leverages [property
matchers](https://jestjs.io/docs/en/snapshot-testing#property-matchers)
to ensure the snapshot itself stays stable, even when updating those
dependencies.
@rwjblue rwjblue merged commit 34abd45 into master Jun 29, 2020
@rwjblue rwjblue deleted the make-stable-for-dependabot-updates branch June 29, 2020 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix snapshot stability for dependency versions.
1 participant