-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump ring to 0.14.0 #110
bump ring to 0.14.0 #110
Conversation
Hi, would it be possible to go forward with this request? As far as I can tell, the Travis checks for nightly builds failed due to the inability to install nightly. |
@alexcrichton could you re-run the CI build? |
It looks like we're getting a true failure. Can you investigate, @ubnt-intrepid? |
@SergioBenitez The failure is caused by Test code (modification of #[test]
fn issue() {
let mut jar = CookieJar::new();
jar.add_original(Cookie::new("name", "value"));
jar.add_original(Cookie::new("second", "two"));
jar.add(Cookie::new("new", "third"));
jar.add(Cookie::new("another", "fourth"));
jar.add(Cookie::new("yac", "fifth"));
jar.remove(Cookie::named("name"));
jar.remove(Cookie::named("another"));
for cookie in jar.iter() {
eprintln!("({}, {})", cookie.name(), cookie.value());
}
} Expected output (the result on stable/beta):
The result on nightly:
(edited) this failure occurs from |
Due to the above patch, there is a possibility that the reference to |
@ubnt-intrepid Thanks for investigating that! Can you rebase on the latest master to rerun tests? Edit: Forgot I could do this! Just did. |
0ae62d0
to
914f760
Compare
@SergioBenitez Thanks! |
Gentle ping to get this reviewed, merged and released. |
It looks like crates.io itself is waiting for this: briansmith/ring#774 (comment) |
@Darkspirit We're actually not on the latest version of cookie, we'll have to update some unmaintained dependencies to get there (and I'm not sure exactly how much work that'll be). But yeah, y'all may want to move on this sooner rather than later since the author is intending to break all crates using 0.13.5 soon. briansmith/ring#774 (comment) |
I agree, cutting a new version of cookie with this would probably help the ecosystem recover from the ring versions purge. |
Please, it's unfair to state this like I'm purposely trying to break people's projects. Now that I'm aware of the Cargo problem (rust-lang/cargo#6609), I may delay yanking 0.13.5. Regardless, it is good to use ring 0.14 because then AES-GCM will start working on AAarch64 devices that don't have the |
No description provided.