Increase PWM frequency for PCA9685 #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will reduce visible PWM flashing with the PCA9685. Mostly noticeable when recording video but also visible with the eye under certain circumstances.
|
It'd be nice to have this as an option for five.Led. Willing to implement this with some guidance. |
| @@ -21,7 +21,7 @@ var Controllers = { | |||
| controller: this.controller, | |||
| bus: this.bus, | |||
| pwmRange: this.pwmRange, | |||
| frequency: 50, // Hz | |||
| frequency: 100, // Hz | |||
There was a problem hiding this comment.
This should actually be 200Hz, can you try that and confirm?
Just change - frequency: 50, // Hz
+ frequency: this.frequency || 200, // HzAnd then this should work: new five.Led({
controller: "PCA9685",
pin: 0,
frequency: ...,
// and so on
});If that doesn't work, then you might need to add: this.frequency = opts.frequency;Here: https://github.com/rwaldron/johnny-five/blob/master/lib/led/led.js#L17 |
rwaldron
added a commit
that referenced
this pull request
Dec 15, 2015
Increase PWM frequency for PCA9685
rwaldron
added a commit
that referenced
this pull request
Dec 15, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will reduce visible PWM flashing with the PCA9685. Mostly noticeable when recording video but also visible with the eye under certain circumstances.