Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor gripper component using controller/device model #698

Closed
Resseguie opened this issue Apr 6, 2015 · 6 comments
Closed

Refactor gripper component using controller/device model #698

Resseguie opened this issue Apr 6, 2015 · 6 comments

Comments

@Resseguie
Copy link
Collaborator

Deemed too specific.

@rwaldron
Copy link
Owner

rwaldron commented Apr 6, 2015

Agreed ;)

@rwaldron
Copy link
Owner

rwaldron commented Apr 6, 2015

OR...

If we can refactor this into a controller/device model and add support for several different types of gripper components, then we can keep it.

@Resseguie Resseguie changed the title Remove gripper component Remove or refactor gripper component Apr 6, 2015
@Resseguie Resseguie mentioned this issue Apr 29, 2015
@Resseguie Resseguie added the 0.9.0 label May 1, 2015
Resseguie added a commit to Resseguie/johnny-five that referenced this issue May 1, 2015
@Resseguie Resseguie changed the title Remove or refactor gripper component Refactor gripper component using controller/device model May 2, 2015
@Resseguie
Copy link
Collaborator Author

@rwaldron So I now vote that we plan to refactor this later to the controller/device model but not let it hold up 0.9.0. You good with removing that label from this issue?

@rwaldron
Copy link
Owner

rwaldron commented May 2, 2015

Works for me

@Resseguie Resseguie removed the 0.9.0 label May 2, 2015
@dtex
Copy link
Collaborator

dtex commented Jan 8, 2018

So gripper is just a scalar applied to a servo and I don't believe it warrants having its own class. I'm going to argue that we move this out to a Johnny-Five module and deprecate the gripper class.

@dtex
Copy link
Collaborator

dtex commented Jan 11, 2018

Hi @Resseguie ,

I caught a bit of the CodeMash drone feed... Flying those things looks hard!

Johnny-Five contributors and maintainers are loathe to close issues where someone has a need. We don't want anyone to ever feel that we don't care, but we just haven't gotten to this yet. Rather than leave it languishing as an open issue we have created a Requested Features page and added your request for a Gripper module.

This is like the 4th request of yours that I've closed in the past two days. Hopefully will be able to start landing some of these features soon.

@dtex dtex closed this as completed Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants