Updated from upstream #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since sidekiq/sidekiq#4804 sidekiq requires to be configured explicitly with a rack session.
`Redis#exists(key)` will return an Integer in redis-rb 4.3. `exists?` returns a boolean, you should use it instead. To opt-in to the new behavior now you can set Redis.exists_returns_integer = true. To disable this message and keep the current (boolean) behaviour of 'exists' you can set `Redis.exists_returns_integer = false`, but this option will be removed in 5.0.
Use ERB::Util.url_encode instead of deprecated URI.escape (#333) Add more rubies to test matrix
It appears that rufus-scheduler version 3.3.3 [uses the Rails timezone](jmettraux/rufus-scheduler@dc9e9df) if Rails is detected. [This commit](4b7eb81) bumps the version of rufus-scheduler, allowing it to upgrade to 3.3.x, which includes the change. This change modifies the README regarding cron syntax, to indicate that the current version of sidekiq_scheduler does use the Rails timezone when parsing cron statements.
This new version includes updates to ruby version plus some documentation updates and updates to some internals about sidekiq
Co-Authored-By: Jason Lee <[email protected]>
This reverts commit 24780e3.
Commit 07b9380 moved the styles to a separate file and mount like the rest of the Sidekiq assets. It looks like the CSS file does not have its path properly set up. The CSS path has been adjusted so that it loads properly now.
The CSS that would run for light-mode users is identical to dark mode's styles. This adjusts the default styles to at least match closer to the rest of Sidekiq's UI for the default theme.
This version includes: - Docs improvements - UI improvement switching from a table to list groups - Use POST requests to prevent CSRF - Brings back redis deprecation warning which will only be fixed in sidekiq-scheduler v4 - Add support for redis-rb >= 4.3
Context: redis/redis-rb#1059 The following is deprecated ```ruby redis.pipelined do redis.get(key) end ``` And should be rewritten as: ```ruby redis.pipelined do |pipeline| pipeline.get(key) end ``` Functionally it makes no difference.
End of life of ruby 2.4 was in March 31, 2020
When a job is scheduled exactly between next and previous runs then round down to the previous run time. Updated specs to reflect this.
Sidekiq 7.3.0 and later added changes to how the web UI for plugins work. - The registration has a first-class API to register a plugin. - See: https://github.com/sidekiq/sidekiq/blob/main/examples/webui-ext/lib/sidekiq-redis_info/web.rb#L20 - The old registration path is still allowed, but will be removed in Sidekiq 8.0. - New stylesheet and script helpers were added to allow linking to scripts and stylesheets for the plugin. They add nouce attributes to protect against XSS attacks. - See: https://github.com/sidekiq/sidekiq/blob/main/examples/webui-ext/readme.md - Sidekiq 8.0 and later will require nouce attributes for all of Sidekiq web. To make this gem forwards compatible with 8.0... - Added a new constant to check for Sidekiq 7.3 and later. - For current and future Sidekiq releases, we'll use the new `style_tag` helper to output the `<link>` tag. Older Sidekiq versions will continue to use the hand-crafted tag as it stands today. - For current and future Sidekiq releases, we'll use the newer registration API for the web UI.
display "at" and "in" in dashboard
The new world order `.register` method for adding pages in the Sidkeiq web UI expects a very specific folder structure of `{webdir}/assets/{tabname}/{assetdir}/{thefile}`.
The gem currently has the structure of `{webdir}/assets/{assetdir}/{thefile}`. Because of this, the latest Sidekiq was mounting the wrong folder paths for the static middleware.
- Moved the CSS file into the now expected folder structure.
- Updated the `<link>` tag in both the old and new implementation in the view to use the changed folder structure.
- Updated the old implementation of registering the page to use the changed folder structure for assets.
Make the gem more secure by requiring that all privileged operations by any of the owners require OTP. Ref: https://guides.rubygems.org/mfa-requirement-opt-in/
``` codespell **/*.rb **/*.md -w -L shedule ```
…really necessary. `SidekiqScheduler::Utils.calc_cron_run_time` only works with a job running periodically. Also, `SidekiqScheduler::Utils.calc_cron_run_time` is only required jobs are execute frequently. So this PR changes to call it when it really needed. Fixes #482.
The scheduled jobs have changed to instance variable by 9f90f5c.
Potential breaking change Ref: #470
Use `Fugit::Cron#match?` to check for exact time match. Use `EtOrbi::EoTime#to_t` instead of `EtOrbi::EoTime#utc` to keep everything in local time. Added specs for aperiodic jobs with and without time zones. Use `Time#floor` instead of `Time#round`.
Convert EtOrbi::EoTime to Time on non-cron jobs Fixed typo.
Prevents introduction of breaking changes at patch or minor version level Close #477
It seems that `tilt` is for `sinatra`. 0313e5b#r14982005 I assume this was needed when the Sidekiq UI depended on `sinatra`, but that has not depended on it since sidekiq/sidekiq#3075. So I think we don't need it now. Let's remove it.
Changes disabled list item background color to better visualize disabled jobs.
LIghter disabled color.
Better option - just dim the text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.