Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency grpc/grpc-swift to v1.13.2 #147

Merged
merged 1 commit into from
Jan 28, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 6, 2023

Mend Renovate

This PR contains the following updates:

Package Update Change
grpc/grpc-swift patch 1.13.1 -> 1.13.2

Release Notes

grpc/grpc-swift

v1.13.2: gRPC Swift 1.13.2

Compare Source

SemVer Patch
Other Changes

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested review from rvolosatovs and strophy as code owners January 6, 2023 13:39
@strophy
Copy link
Collaborator

strophy commented Jan 9, 2023

I think something is not working correctly in how we build and copy the plugin for this language, because the step of copying protoc-gen-swift into the upx stage runs from cache, rather than using the newly built binary. It might be worth unpicking the enormous heredoc RUN command in the swift build, since it doesn't offer any benefits in an intermediate build stage, and seems to be interfering with Docker's cache hit detection.

@rvolosatovs
Copy link
Owner

I think something is not working correctly in how we build and copy the plugin for this language, because the step of copying protoc-gen-swift into the upx stage runs from cache, rather than using the newly built binary. It might be worth unpicking the enormous heredoc RUN command in the swift build, since it doesn't offer any benefits in an intermediate build stage, and seems to be interfering with Docker's cache hit detection.

Interesting. Could it be that there was no actual change in the dependency?
Is there a way we can query the version from the binary itself to check that the correct version is actually used?

@strophy
Copy link
Collaborator

strophy commented Jan 28, 2023

You're right! The built binary is bit-identical, I checked this by running md5sum and also verified that the linux binaries released at grpc/grpc-swift are also bit-identical for versions 1.13.1 and 1.13.2.

@renovate renovate bot force-pushed the renovate/grpc-grpc-swift-1.x branch from de67e71 to 813232e Compare January 28, 2023 02:09
@strophy strophy merged commit 5602ac8 into main Jan 28, 2023
@strophy strophy deleted the renovate/grpc-grpc-swift-1.x branch January 28, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants