Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gorm plugin #102

Merged
merged 4 commits into from
Nov 29, 2022
Merged

Add gorm plugin #102

merged 4 commits into from
Nov 29, 2022

Conversation

AFMiziara
Copy link
Contributor

Adding protoc-gen-gorm to the image.

@rvolosatovs
Copy link
Owner

LGTM, thanks!

@rvolosatovs
Copy link
Owner

rvolosatovs commented Jun 23, 2022

Hmm, looks like CI is not too happy:

 > [linux/amd64 protoc_gen_gorm  2/11] RUN curl -sSL https://api.github.com/repos/infobloxopen/protoc-gen-gorm/tarball/v${PROTOC_GEN_GORM_VERSION} | tar xz --strip 1 -C /go/src/github.com/infobloxopen/protoc-gen-gorm:
#0 5.750 tar: invalid magic
#0 5.750 tar: short read
------
Dockerfile:116
--------------------
 114 |     RUN mkdir -p ${GOPATH}/src/github.com/infobloxopen/protoc-gen-gorm
 115 |     ARG PROTOC_GEN_GORM_VERSION
 116 | >>> RUN curl -sSL https://api.github.com/repos/infobloxopen/protoc-gen-gorm/tarball/v${PROTOC_GEN_GORM_VERSION} | tar xz --strip 1 -C ${GOPATH}/src/github.com/infobloxopen/protoc-gen-gorm
 117 |     WORKDIR ${GOPATH}/src/github.com/infobloxopen/protoc-gen-gorm
 118 |     RUN mkdir /protoc-gen-gorm-out
--------------------
error: failed to solve: process "/bin/sh -c curl -sSL https://api.github.com/repos/infobloxopen/protoc-gen-gorm/tarball/v${PROTOC_GEN_GORM_VERSION} | tar xz --strip 1 -C ${GOPATH}/src/github.com/infobloxopen/protoc-gen-gorm" did not complete successfully: exit code: 1

Could you take a look?

Copy link
Owner

@rvolosatovs rvolosatovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure all lines are lexicographically sorted, then LGTM

.github/workflows/dockerimage.yml Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
@rvolosatovs rvolosatovs enabled auto-merge (rebase) November 29, 2022 19:24
@rvolosatovs rvolosatovs added this to the 4.0.0 milestone Nov 29, 2022
@rvolosatovs rvolosatovs merged commit ff1c1ef into rvolosatovs:main Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants