Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"parseFromDeveloperNoteTrimCharacters" parameter missing in Sync-XliffTranslations / Test-BcAppXliffTranslations #39

Closed
fvet opened this issue Jan 3, 2023 · 4 comments
Labels
enhancement New feature or request shipped Issue is available in the public release.

Comments

@fvet
Copy link

fvet commented Jan 3, 2023

Hi @rvanbekkum ,

We've finally moved the translation logic to our pipelines and are 99% close to auto-generate translations as part of the build process. However, we lack support for the parseFromDeveloperNoteTrimCharacters setting in PS Xliff Sync (although it is supported in VS Code > rvanbekkum/vsc-xliff-sync#100)

Our PS script currently looks like this ...

...
$SyncAdditionalParameters = @{
    "preserveTargetAttributesOrder"   = $true
    "findBySource"                    = $true 
    "findBySourceAndDeveloperNote"    = $true
    "parseFromDeveloperNote"          = $true
    "parseFromDeveloperNoteOverwrite" = $true
    "parseFromDeveloperNoteSeparator" = "||"
    # parseFromDeveloperNoteTrimCharacters" = "\""    ### <<< This is currently missing
}

...

Test-BcAppXliffTranslations -printProblems -appFolders $AppFolders -translationRules @("OptionMemberCount", "OptionLeadingSpaces", "Placeholders", "ConsecutiveSpacesConsistent", "ConsecutiveSpacesExist") -restrictErrorsToLanguages @("nl-BE", "nl-NL") -buildProjectFolder $BuildProjectFolder -syncAdditionalParameters $SyncAdditionalParameters -AzureDevOps $AzureDevOps # -reportProgress -FormatTranslationUnit 

... but we would like to specify parseFromDeveloperNoteTrimCharacters similar to how we can specify this in VS Code.

Any chance of integrating below commit into the PS version of XLiff Sync?
rvanbekkum/vsc-xliff-sync@fc0ba6a

@rvanbekkum rvanbekkum added the enhancement New feature or request label Jan 4, 2023
@rvanbekkum
Copy link
Owner

Hi @fvet,

I think that should be possible with limited effort, so I'll add it soon.

@fvet
Copy link
Author

fvet commented Jan 26, 2023

@rvanbekkum Sorry for being pushy, but any update on the progress of this issue?

rvanbekkum pushed a commit that referenced this issue Jan 26, 2023
@rvanbekkum
Copy link
Owner

Hi @fvet,
I have just pushed a commit which will add support for the parseFromDeveloperNoteTrimCharacters parameter.
I will need to test and release it. If you have any feedback then please let me know as well.
The implementation is taken from the vsc-xliff-sync implementation and converted to PowerShell.

@rvanbekkum rvanbekkum added the ships-in-future-update Resolution will be available in the next release. label Jan 26, 2023
@rvanbekkum
Copy link
Owner

The new parameter is now available in version 1.8.0.0.

@rvanbekkum rvanbekkum added shipped Issue is available in the public release. and removed ships-in-future-update Resolution will be available in the next release. labels Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request shipped Issue is available in the public release.
Projects
None yet
Development

No branches or pull requests

2 participants